issue_comments

Table actions

9 rows where author_association = "CONTRIBUTOR", issue = 283566613 and user = 12229877 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • Zac-HD · 9 ✖

issue 1

  • Support RGB[A] arrays in plot.imshow() · 9 ✖

author_association 1

  • CONTRIBUTOR · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
356498223 https://github.com/pydata/xarray/pull/1796#issuecomment-356498223 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1NjQ5ODIyMw== Zac-HD 12229877 2018-01-10T04:42:44Z 2018-01-10T13:55:50Z CONTRIBUTOR

@shoyer makes some good points about things that should be fixed upstream in Matplotlib - namely normalization of RGB images, but I'm also going to move my color fixes (clipping instead of modulo) upstream instead. Timeline:

  1. I edit this PR, it gets merged, Xarray 10.1 (ETA soonish?) can display RGB images just like Matplotlib
  2. I finish my upstream PR, Matplotlib 2.2 (ETA later this month (!)) supports normalization of RGB images and fixes the modulo/clip bug
  3. Once the matplotlib API is merged, I make a new PR against Xarray to support the same interface (including on older matplotlib versions)
 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613
356519422 https://github.com/pydata/xarray/pull/1796#issuecomment-356519422 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1NjUxOTQyMg== Zac-HD 12229877 2018-01-10T07:14:16Z 2018-01-10T07:14:16Z CONTRIBUTOR

Looks like TestDatetimePlot.test_datetime_line_plot is failing, but I'm pretty sure that's nothing to do with me (and it passed twice on Travis!).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613
356272643 https://github.com/pydata/xarray/pull/1796#issuecomment-356272643 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1NjI3MjY0Mw== Zac-HD 12229877 2018-01-09T12:38:28Z 2018-01-09T12:38:28Z CONTRIBUTOR

Okay... I've now seen three Travis runs. In every one there's been a pass, a fail, and three errors... but different jobs each time. At this point I'm ready to give up and wait for the Travis team to fix it 😕

The code is ready to go though! 🎉 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613
356223193 https://github.com/pydata/xarray/pull/1796#issuecomment-356223193 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1NjIyMzE5Mw== Zac-HD 12229877 2018-01-09T09:07:58Z 2018-01-09T09:07:58Z CONTRIBUTOR

More review fixes 😄

I'm pretty sure the build failure is just Travis being flaky - it passes on my machine. Could someone restart it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613
355743363 https://github.com/pydata/xarray/pull/1796#issuecomment-355743363 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1NTc0MzM2Mw== Zac-HD 12229877 2018-01-06T12:18:56Z 2018-01-06T13:33:48Z CONTRIBUTOR

OK, @shoyer & @fmaussion - I think I'm done again!

The only thing I haven't done is change the handling of robust=True, as anything beyond "scale and clip 2nd-to-98th percentiles to [0, 1]" seems fraught with complications. If this is not what the user intended, it's at least the obvious default behaviour and should be simple to understand.

Hopefully this covers the substantial changes; but let me know if there's anything else as I'd really like this merged before the 0.10.1 release - and ideally released in time for demos at my summer school in January 😄

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613
353773905 https://github.com/pydata/xarray/pull/1796#issuecomment-353773905 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1Mzc3MzkwNQ== Zac-HD 12229877 2017-12-24T09:08:10Z 2018-01-06T12:06:44Z CONTRIBUTOR

Thanks for the review @shoyer! I'll do what I can in the next few days, but that might not be much at all before I get back from a no-internet camping trip around Jan 8th. Items:

  • [x] add validation and tests for rgb argument
  • [x] don't mutate the input data! (I think it doesn't, but obviously this needs to be checked)
  • [x] simplify order heuristic, to "use last dimension of size 3 or 4 as rgb; warn if there are multiple possible"
  • [x] update rasterio example in gallery
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613
353351362 https://github.com/pydata/xarray/pull/1796#issuecomment-353351362 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1MzM1MTM2Mg== Zac-HD 12229877 2017-12-21T13:31:28Z 2017-12-21T13:31:28Z CONTRIBUTOR

Done - now with optional argument and nicer commit history, Anything else?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613
353260924 https://github.com/pydata/xarray/pull/1796#issuecomment-353260924 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1MzI2MDkyNA== Zac-HD 12229877 2017-12-21T05:21:41Z 2017-12-21T05:21:41Z CONTRIBUTOR

Optional argument coming up then 😄

Anything else I need to do?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613
353225923 https://github.com/pydata/xarray/pull/1796#issuecomment-353225923 https://api.github.com/repos/pydata/xarray/issues/1796 MDEyOklzc3VlQ29tbWVudDM1MzIyNTkyMw== Zac-HD 12229877 2017-12-21T00:51:35Z 2017-12-21T00:53:02Z CONTRIBUTOR

I like this. My main concern is that I'd like a fully explicit way to opt into this behavior. Perhaps rgb='band' and/or rgba='band'?

I have a pretty strong preference for RGB images 'just working' - requiring a new argument would mean imshow has a different signature to all other plot methods without adding any information. If it's an optional argument, it barely does anything - in the rare case where the heuristic fails, you can supply x and y dims instead.

In many ways showing an RGB image is a special case, but this is the least-special-case I could make work - and it's consistent with the obvious meaning and upstream behavior of imshow.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support RGB[A] arrays in plot.imshow() 283566613

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);