issue_comments: 353773905

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1796#issuecomment-353773905 https://api.github.com/repos/pydata/xarray/issues/1796 353773905 MDEyOklzc3VlQ29tbWVudDM1Mzc3MzkwNQ== 12229877 2017-12-24T09:08:10Z 2018-01-06T12:06:44Z CONTRIBUTOR

Thanks for the review @shoyer! I'll do what I can in the next few days, but that might not be much at all before I get back from a no-internet camping trip around Jan 8th. Items:

  • [x] add validation and tests for rgb argument
  • [x] don't mutate the input data! (I think it doesn't, but obviously this needs to be checked)
  • [x] simplify order heuristic, to "use last dimension of size 3 or 4 as rgb; warn if there are multiple possible"
  • [x] update rasterio example in gallery
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   283566613