home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 353225923

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1796#issuecomment-353225923 https://api.github.com/repos/pydata/xarray/issues/1796 353225923 MDEyOklzc3VlQ29tbWVudDM1MzIyNTkyMw== 12229877 2017-12-21T00:51:35Z 2017-12-21T00:53:02Z CONTRIBUTOR

I like this. My main concern is that I'd like a fully explicit way to opt into this behavior. Perhaps rgb='band' and/or rgba='band'?

I have a pretty strong preference for RGB images 'just working' - requiring a new argument would mean imshow has a different signature to all other plot methods without adding any information. If it's an optional argument, it barely does anything - in the rare case where the heuristic fails, you can supply x and y dims instead.

In many ways showing an RGB image is a special case, but this is the least-special-case I could make work - and it's consistent with the obvious meaning and upstream behavior of imshow.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  283566613
Powered by Datasette · Queries took 0.775ms · About: xarray-datasette