issue_comments

Table actions

2 rows where author_association = "CONTRIBUTOR" and issue = 185441216 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Add remaining date units to conventions.py · 2 ✖

author_association 1

  • CONTRIBUTOR · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
256541189 https://github.com/pydata/xarray/issues/1062#issuecomment-256541189 https://api.github.com/repos/pydata/xarray/issues/1062 MDEyOklzc3VlQ29tbWVudDI1NjU0MTE4OQ== mcgibbon 12307589 2016-10-27T04:01:55Z 2016-10-27T04:01:55Z CONTRIBUTOR

I think using a more informative error when particularly year and month are used would be the right way to go. It would also probably be fine to require integer months/years, but Pandas also has weird behavior:

In[6]: pd.to_timedelta(1, 'M') Out[6]: Timedelta('30 days 10:29:06') In[7]: pd.to_timedelta(1.5, 'M') Out[7]: Timedelta('30 days 10:29:06')

Because of this it would take a significant rework of decode_cf_datetime in conventions.py to actually implement integer months working properly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add remaining date units to conventions.py 185441216
256506227 https://github.com/pydata/xarray/issues/1062#issuecomment-256506227 https://api.github.com/repos/pydata/xarray/issues/1062 MDEyOklzc3VlQ29tbWVudDI1NjUwNjIyNw== mcgibbon 12307589 2016-10-26T23:27:43Z 2016-10-26T23:27:43Z CONTRIBUTOR

@jhamman It does sound sensible to have integer months accepted as a unit. However, Udunits isn't sensible (in this way), and CF conventions refer to Udunits. If we are to treat months as Udunits months, then each month is 30.42 or a similar number of days, and February 1st + 1 month is not the 1st of March.

The CF-compatible way to do it is have the length of a month be based on the length of a year for the current calendar. Even then it's not well defined since a common and leap year are different lengths...

At the very least it should be helpful to see an error message raised explaining why months and years aren't acceptable units when using them is attempted, possibly referring to this github issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add remaining date units to conventions.py 185441216

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);