issue_comments

Table actions

4 rows where author_association = "CONTRIBUTOR" and issue = 1477931237 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement · 4 ✖

author_association 1

  • CONTRIBUTOR · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1349626420 https://github.com/pydata/xarray/pull/7361#issuecomment-1349626420 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85Qcao0 mroeschke 10647082 2022-12-13T20:12:28Z 2022-12-13T20:12:28Z CONTRIBUTOR

Great added the whatsnew note and just removed the arguments

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237
1347186812 https://github.com/pydata/xarray/pull/7361#issuecomment-1347186812 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85QTHB8 mroeschke 10647082 2022-12-12T19:40:21Z 2022-12-12T19:40:21Z CONTRIBUTOR

I guess this could be a "Breaking Change" in the next release's What's New. Let me know if that's the direction you're still leaning

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237
1346807178 https://github.com/pydata/xarray/pull/7361#issuecomment-1346807178 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85QRqWK aulemahal 20629530 2022-12-12T16:11:29Z 2022-12-12T16:11:29Z CONTRIBUTOR

Hmm, I don't think so! Thanks for the heads up.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237
1339701584 https://github.com/pydata/xarray/pull/7361#issuecomment-1339701584 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85P2jlQ mroeschke 10647082 2022-12-06T17:13:04Z 2022-12-06T17:13:04Z CONTRIBUTOR

I wonder if it's appropriate to simply remove these arguments altogether following pandas?

Sure, happy to remove this method and tolerance from CFTimeIndex.get_loc. Would that require a deprecation in xarray or can they simply be removed if CFTimeIndex.get_loc is "private"?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);