issue_comments

Table actions

8 rows where issue = 1477931237 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1352174057 https://github.com/pydata/xarray/pull/7361#issuecomment-1352174057 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85QmInp mathause 10194086 2022-12-14T21:03:50Z 2022-12-14T21:03:50Z MEMBER

Thanks @mroeschke 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237
1349626420 https://github.com/pydata/xarray/pull/7361#issuecomment-1349626420 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85Qcao0 mroeschke 10647082 2022-12-13T20:12:28Z 2022-12-13T20:12:28Z CONTRIBUTOR

Great added the whatsnew note and just removed the arguments

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237
1347554206 https://github.com/pydata/xarray/pull/7361#issuecomment-1347554206 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85QUgue spencerkclark 6628425 2022-12-13T00:07:51Z 2022-12-13T00:07:51Z MEMBER

Yes, I think that's what we'll end up going with @mroeschke. Thanks for your patience as we worked it out.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237
1347186812 https://github.com/pydata/xarray/pull/7361#issuecomment-1347186812 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85QTHB8 mroeschke 10647082 2022-12-12T19:40:21Z 2022-12-12T19:40:21Z CONTRIBUTOR

I guess this could be a "Breaking Change" in the next release's What's New. Let me know if that's the direction you're still leaning

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237
1346807178 https://github.com/pydata/xarray/pull/7361#issuecomment-1346807178 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85QRqWK aulemahal 20629530 2022-12-12T16:11:29Z 2022-12-12T16:11:29Z CONTRIBUTOR

Hmm, I don't think so! Thanks for the heads up.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237
1346767759 https://github.com/pydata/xarray/pull/7361#issuecomment-1346767759 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85QRguP dcherian 2448579 2022-12-12T15:51:55Z 2022-12-12T15:52:31Z MEMBER

I don't know how many people use the lower level methods of CFTimeIndexes like get_loc outside of xarray data structures.

I sometimes do this with a general pd.Index but it's pretty rare. In any case, I think any user using get_loc would be fairly advanced and can figure out the workaround pretty easily.

@aulemahal does xclim or its related packages use CFTimeIndex.get_loc at all to convert a label to an integer index?(EDIT: a search didn't turn up anything)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237
1345679164 https://github.com/pydata/xarray/pull/7361#issuecomment-1345679164 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85QNW88 spencerkclark 6628425 2022-12-11T22:50:57Z 2022-12-11T22:50:57Z MEMBER

Technically I think we would consider get_loc to be public (both due to how it is named and in that it is at least primitively documented). That said, I don't know how many people use the lower level methods of CFTimeIndexes like get_loc outside of xarray data structures.

My inclination is that it would not require a deprecation cycle, given the warning had already been being raised as in the example above. It's true though that this warning was not being emitted in the case that key was a string, so perhaps it's a little borderline. Maybe @dcherian or @mathause, do you have any thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237
1339701584 https://github.com/pydata/xarray/pull/7361#issuecomment-1339701584 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85P2jlQ mroeschke 10647082 2022-12-06T17:13:04Z 2022-12-06T17:13:04Z CONTRIBUTOR

I wonder if it's appropriate to simply remove these arguments altogether following pandas?

Sure, happy to remove this method and tolerance from CFTimeIndex.get_loc. Would that require a deprecation in xarray or can they simply be removed if CFTimeIndex.get_loc is "private"?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);