issue_comments

Table actions

6 rows where author_association = "CONTRIBUTOR" and issue = 1093466537 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • Implement multiplication of cftime Tick offsets by floats · 6 ✖

author_association 1

  • CONTRIBUTOR · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1037063748 https://github.com/pydata/xarray/pull/6135#issuecomment-1037063748 https://api.github.com/repos/pydata/xarray/issues/6135 IC_kwDOAMm_X8490FZE aaronspring 12237157 2022-02-12T08:28:47Z 2022-02-12T08:28:47Z CONTRIBUTOR

Nice work @aaronspring! I think this is ready to go.

Thank you so much @spencerkclark for your guidance 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement multiplication of cftime Tick offsets by floats 1093466537
1032848596 https://github.com/pydata/xarray/pull/6135#issuecomment-1032848596 https://api.github.com/repos/pydata/xarray/issues/6135 IC_kwDOAMm_X849kATU aaronspring 12237157 2022-02-08T17:03:18Z 2022-02-08T17:03:18Z CONTRIBUTOR

thank you very much for the guidance here. I hope this is now close to how you envisioned this. I merely wanted to get a small improvement in functionality and didnt expect to learn so much. thank you so far @spencerkclark 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement multiplication of cftime Tick offsets by floats 1093466537
1025184642 https://github.com/pydata/xarray/pull/6135#issuecomment-1025184642 https://api.github.com/repos/pydata/xarray/issues/6135 IC_kwDOAMm_X849GxOC aaronspring 12237157 2022-01-30T16:58:23Z 2022-02-01T15:54:29Z CONTRIBUTOR

failing tests are unrelated to cftime IMO

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement multiplication of cftime Tick offsets by floats 1093466537
1025163440 https://github.com/pydata/xarray/pull/6135#issuecomment-1025163440 https://api.github.com/repos/pydata/xarray/issues/6135 IC_kwDOAMm_X849GsCw aaronspring 12237157 2022-01-30T15:09:52Z 2022-01-30T15:09:52Z CONTRIBUTOR 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   Implement multiplication of cftime Tick offsets by floats 1093466537
1008437041 https://github.com/pydata/xarray/pull/6135#issuecomment-1008437041 https://api.github.com/repos/pydata/xarray/issues/6135 IC_kwDOAMm_X848G4cx aaronspring 12237157 2022-01-09T22:33:03Z 2022-01-09T22:33:03Z CONTRIBUTOR

thanks for the reviews so far @spencerkclark @Illviljan @max-sixty - I think I implemented the suggestions and am looking forward to your next reviews

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement multiplication of cftime Tick offsets by floats 1093466537
1008277351 https://github.com/pydata/xarray/pull/6135#issuecomment-1008277351 https://api.github.com/repos/pydata/xarray/issues/6135 IC_kwDOAMm_X848GRdn aaronspring 12237157 2022-01-09T11:13:01Z 2022-01-09T11:13:01Z CONTRIBUTOR

Would you remove the isinstance checks? I though that mypy does check at runtime, so it would detect a wrong input by the user. (I am still new to typing etc)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement multiplication of cftime Tick offsets by floats 1093466537

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);