home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 1008277351

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6135#issuecomment-1008277351 https://api.github.com/repos/pydata/xarray/issues/6135 1008277351 IC_kwDOAMm_X848GRdn 12237157 2022-01-09T11:13:01Z 2022-01-09T11:13:01Z CONTRIBUTOR

Would you remove the isinstance checks? I though that mypy does check at runtime, so it would detect a wrong input by the user. (I am still new to typing etc)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1093466537
Powered by Datasette · Queries took 0.784ms · About: xarray-datasette