issues: 616432851

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
616432851 MDExOlB1bGxSZXF1ZXN0NDE2NTQ0MzE4 4053 Fix html repr in untrusted notebooks (plain text fallback) 4160723 closed 0     5 2020-05-12T07:38:22Z 2022-03-29T07:10:07Z 2020-05-20T17:06:40Z MEMBER   0 pydata/xarray/pulls/4053
  • [x] Closes #4041
  • [x] Tests added
  • [x] Passes isort -rc . && black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

This is not very elegant (actually plain text repr is already included in the notebook as text/plain mime type but it is ignored when text/html mime type is present), but it seems to work. I haven't found a better workaround.

I don't really know if this can be properly tested (I only added a basic test).

Steps to test this fix:

  • To "untrust" a notebook: open an existing notebook with a simple editor, manually edit one output cell with a xarray object repr, and save the ipynb file.
  • Open this notebook with the Notebook app, you should see the plain text repr.
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4053/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables