issue_comments

Table actions

5 rows where issue = 616432851 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Fix html repr in untrusted notebooks (plain text fallback) · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
634932598 https://github.com/pydata/xarray/pull/4053#issuecomment-634932598 https://api.github.com/repos/pydata/xarray/issues/4053 MDEyOklzc3VlQ29tbWVudDYzNDkzMjU5OA== dcherian 2448579 2020-05-27T20:51:48Z 2020-05-27T20:51:48Z MEMBER

just confirmed that the fallback works perfectly. Thanks @benbovy !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix html repr in untrusted notebooks (plain text fallback) 616432851
631605148 https://github.com/pydata/xarray/pull/4053#issuecomment-631605148 https://api.github.com/repos/pydata/xarray/issues/4053 MDEyOklzc3VlQ29tbWVudDYzMTYwNTE0OA== dcherian 2448579 2020-05-20T17:06:34Z 2020-05-20T17:06:34Z MEMBER

Thanks @benbovy 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix html repr in untrusted notebooks (plain text fallback) 616432851
627587077 https://github.com/pydata/xarray/pull/4053#issuecomment-627587077 https://api.github.com/repos/pydata/xarray/issues/4053 MDEyOklzc3VlQ29tbWVudDYyNzU4NzA3Nw== shoyer 1217238 2020-05-12T20:51:40Z 2020-05-12T20:51:40Z MEMBER

I sent a support request to GitHub asking for supporting the hidden attribute. We'll see if we get a response!

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix html repr in untrusted notebooks (plain text fallback) 616432851
627558711 https://github.com/pydata/xarray/pull/4053#issuecomment-627558711 https://api.github.com/repos/pydata/xarray/issues/4053 MDEyOklzc3VlQ29tbWVudDYyNzU1ODcxMQ== benbovy 4160723 2020-05-12T19:54:40Z 2020-05-12T19:54:40Z MEMBER

Mmm it looks like Github's notebook renderer removes the hidden attribute of the xr-wrap div in addition to removing CSS. That's unfortunate.

I tested this workaround in jupyterlab, classic notebook and nbviewer. It works as expected. I haven't tested other front-ends (Colab, vscode, etc.).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix html repr in untrusted notebooks (plain text fallback) 616432851
627439451 https://github.com/pydata/xarray/pull/4053#issuecomment-627439451 https://api.github.com/repos/pydata/xarray/issues/4053 MDEyOklzc3VlQ29tbWVudDYyNzQzOTQ1MQ== shoyer 1217238 2020-05-12T16:06:20Z 2020-05-12T16:06:40Z MEMBER

I tested this out exporting a notebook to Github: https://gist.github.com/shoyer/6ee36acd164116fee4681f6237ca5249

Here's what I see:

Somehow we get both text and malformed HTML? :(

It's definitely still an improvement over what we had before, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix html repr in untrusted notebooks (plain text fallback) 616432851

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);