issue_comments

Table actions

2 rows where issue = 480259102 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • template docstrings for join, data_vars, coords etc. · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
520931723 https://github.com/pydata/xarray/issues/3214#issuecomment-520931723 https://api.github.com/repos/pydata/xarray/issues/3214 MDEyOklzc3VlQ29tbWVudDUyMDkzMTcyMw== dcherian 2448579 2019-08-13T17:34:09Z 2019-08-13T17:34:09Z MEMBER

the quasi-metaprogramming of templates makes that more difficult.

:+1:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   template docstrings for join, data_vars, coords etc. 480259102
520930519 https://github.com/pydata/xarray/issues/3214#issuecomment-520930519 https://api.github.com/repos/pydata/xarray/issues/3214 MDEyOklzc3VlQ29tbWVudDUyMDkzMDUxOQ== max-sixty 5635139 2019-08-13T17:30:56Z 2019-08-13T17:30:56Z MEMBER

I'm -0 on overhauling. I find when developing, looking up a method and seeing the docstring is v helpful, and the quasi-metaprogramming of templates makes that more difficult. (I find I need to start ipython and look up the docstring with method?)

But we should balance that against the annoyance and error is repetition. e.g. here, the compat argument has two slightly different descriptions (both correct, but not efficient to write it twice): https://github.com/pydata/xarray/blob/master/xarray/core/dataset.py#L3393 https://github.com/pydata/xarray/blob/master/xarray/core/merge.py#L522

To the extent we can reduce the number of methods, (e.g. use the same method for DataArray & Dataset, referring to an 'object' in the docstring), that's even better. But not always possible.

If there's a severe case we could start on and assess the overlap, I'm +0.2 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   template docstrings for join, data_vars, coords etc. 480259102

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);