issue_comments: 520930519

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3214#issuecomment-520930519 https://api.github.com/repos/pydata/xarray/issues/3214 520930519 MDEyOklzc3VlQ29tbWVudDUyMDkzMDUxOQ== 5635139 2019-08-13T17:30:56Z 2019-08-13T17:30:56Z MEMBER

I'm -0 on overhauling. I find when developing, looking up a method and seeing the docstring is v helpful, and the quasi-metaprogramming of templates makes that more difficult. (I find I need to start ipython and look up the docstring with method?)

But we should balance that against the annoyance and error is repetition. e.g. here, the compat argument has two slightly different descriptions (both correct, but not efficient to write it twice): https://github.com/pydata/xarray/blob/master/xarray/core/dataset.py#L3393 https://github.com/pydata/xarray/blob/master/xarray/core/merge.py#L522

To the extent we can reduce the number of methods, (e.g. use the same method for DataArray & Dataset, referring to an 'object' in the docstring), that's even better. But not always possible.

If there's a severe case we could start on and assess the overlap, I'm +0.2 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   480259102