home / github

Menu
  • Search all tables
  • GraphQL API

pull_requests

Table actions
  • GraphQL API for pull_requests

6 rows where user = 45271239

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: state, draft, created_at (date), updated_at (date), closed_at (date), merged_at (date)

id ▼ node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
1709975387 PR_kwDOAMm_X85l7Cdb 8698 closed 0 New alignment option: `join='strict'` etienneschalk 45271239 Title: New alignment option: `join='strict'` - [ ] Closes #8231 - [x] Closes #6806 - [x] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [x] What's new entry - [x] Refer to PR ID (cannot be done before the PR has been created) - [x] New functions/methods are listed in `api.rst` - No new functions/methods. ## Motive This PR is motivated by solving of the following issues: - xr.concat concatenates along dimensions that it wasn't asked to #8231 - New alignment option: "exact" without broadcasting OR Turn off automatic broadcasting #6806 **The current PR does not solve the unexpected issue described in #8231 without a change in user-code**. Indeed, in the tests written, it is shown that to get the said expected behavior, the user would have to use the new `join='strict'` mode suggested in #6806 for the concatenation operation. Only in that case, the uniqueness of the indexed dimensions' names will be checked, re-using the same logic that was already applied for `join='override'` in `Aligner.find_matching_indexes` This may not be enough to fix #8231. If that isn't, I can split the PR into two, first one for adding the `join='strict'` for #6806 and later on one for #8321. ## Technical Details I try to detail here my thought process. Please correct me if there is anything wrong. This is my first time digging into this core logic! Here is my understanding of the terms: - An **indexed dimension** is attached to a coordinate variable - An **unindexed dimension** is not attached to a coordinate variable (_"Dimensions without coordinates"_) Input data for Scenario 1, tested in `test_concat_join_coordinate_variables_non_asked_dims` ```python ds1 = Dataset( coords={ "x_center": ("x_center", [1, 2, 3]), "x_outer": ("x_outer", [0.5, 1.5, 2.5, 3.5]), }, ) ds2 = Dataset( coords={ "x_center": ("x_center", [4, 5, 6]), … 2024-02-03T17:58:43Z 2024-02-25T09:09:37Z 2024-02-25T09:09:37Z   c095bc726e956aafdfbe35efcacff5dafdda2f89     0 5cc61b08f2a96c71dd497a18d0e48d0228942844 d9760f30662b219182cdc8dedc04dfbe7771942b CONTRIBUTOR   xarray 13221727 https://github.com/pydata/xarray/pull/8698  
1710461983 PR_kwDOAMm_X85l85Qf 8702 closed 0 Add a simple `nbytes` representation in DataArrays and Dataset `repr` etienneschalk 45271239 <!-- Feel free to remove check-list items aren't relevant to your change --> Edit: in contrary to what the title suggest, this is not an opt-in feature, it is enabled by default - [x] Closes #8690 - (or at least is a proposal) - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - ~~[ ] New functions/methods are listed in `api.rst`~~ 2024-02-04T16:37:41Z 2024-02-20T11:15:51Z 2024-02-07T20:47:37Z 2024-02-07T20:47:37Z db680b0d99d4dacd9b0f520f9ee71d5c052516c0     0 d4a816da17d47d979b06da112ba1a9679520d6da 0eb66587c44411abc668e96881a51e1b99e1eb9e CONTRIBUTOR   xarray 13221727 https://github.com/pydata/xarray/pull/8702  
1716494333 PR_kwDOAMm_X85mT5_9 8719 closed 0 Test formatting platform etienneschalk 45271239 Follow up #8702 / https://github.com/pydata/xarray/pull/8702#issuecomment-1932851112 The goal is to remove the not elegant OS-dependant checks introduced during the testing of #8702 A simple way to do so is to use unsigned integer as dtypes for tests involving data array representations on multiple OSes. Indeed, this solves the issue of the default dtypes being not printed in the repr, with default dtyps varying according to the OS. The tests show that the concerned dtypes are `int32` (for the Windows CI) and `int64` (for Ubuntu and macOS CIs). Using `uint64` should fix both the varying size and the varying numpy array repr. ~~- [ ] Closes #xxxx~~ - [x] Tests added ~~- [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst`~~ ~~- [ ] New functions/methods are listed in `api.rst`~~ 2024-02-07T21:41:23Z 2024-02-09T03:01:35Z 2024-02-09T03:01:35Z 2024-02-09T03:01:35Z 0ad7fa78c6c883268030eef42fe0262bdd94af95     0 090894a6ba0306700d5bab151685b705427af651 97c8c18174a8354ced1d22b98d7a8c141c3f9c9d CONTRIBUTOR
{
    "enabled_by": {
        "login": "max-sixty",
        "id": 5635139,
        "node_id": "MDQ6VXNlcjU2MzUxMzk=",
        "avatar_url": "https://avatars.githubusercontent.com/u/5635139?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/max-sixty",
        "html_url": "https://github.com/max-sixty",
        "followers_url": "https://api.github.com/users/max-sixty/followers",
        "following_url": "https://api.github.com/users/max-sixty/following{/other_user}",
        "gists_url": "https://api.github.com/users/max-sixty/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/max-sixty/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/max-sixty/subscriptions",
        "organizations_url": "https://api.github.com/users/max-sixty/orgs",
        "repos_url": "https://api.github.com/users/max-sixty/repos",
        "events_url": "https://api.github.com/users/max-sixty/events{/privacy}",
        "received_events_url": "https://api.github.com/users/max-sixty/received_events",
        "type": "User",
        "site_admin": false
    },
    "merge_method": "squash",
    "commit_title": "Test formatting platform (#8719)",
    "commit_message": "* Test formatting platform\r\n\r\n* Default is float64\r\n\r\n* Try to differentiate between OS-dependant and independant dtypes for CI safety\r\n\r\n* wip\r\n\r\n* fixed tests\r\n\r\n* forgot one test\r\n\r\n---------\r\n\r\nCo-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>"
}
xarray 13221727 https://github.com/pydata/xarray/pull/8719  
1719955573 PR_kwDOAMm_X85mhHB1 8729 closed 0 Reinforce alignment checks when `join='exact'` etienneschalk 45271239 :information_source: Companion PR of #8698 Aims to check the consequences of transforming `join='exact'` aligments into `join='strict'` ones. 2024-02-09T20:36:46Z 2024-02-25T12:51:54Z 2024-02-25T12:51:54Z   031bfdded27601d1be30d8db69e8f35885bc1b9a     1 b55ccbd67f9e50bf25aa9dbcee22db02ed0fcaf0 3d490ec3f1cd0ac9114a5d270550ce6e7864ade7 CONTRIBUTOR   xarray 13221727 https://github.com/pydata/xarray/pull/8729  
1730983945 PR_kwDOAMm_X85nLLgJ 8761 open 0 Use ruff for formatting etienneschalk 45271239 <!-- Feel free to remove check-list items aren't relevant to your change --> - [ ] Closes #8760 ~~- [ ] Tests added~~ ~~- [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst`~~ ~~- [ ] New functions/methods are listed in `api.rst`~~ Note: many inline `...` obtain their own line. Running `black .` would have produced the same result 2024-02-17T16:04:18Z 2024-02-27T20:11:57Z     9718f54976137b098c273e21a7e1faf8817a5e0f     1 473bec682f8b53ae38ce3b8d3099f6382258eacc 2983c5326c085334ed3e262db1ac3faa0e784586 CONTRIBUTOR   xarray 13221727 https://github.com/pydata/xarray/pull/8761  
1742180709 PR_kwDOAMm_X85n15Fl 8784 closed 0 Do not attempt to broadcast when global option ``arithmetic_broadcast=False`` etienneschalk 45271239 **Follow-up PR after #8698** - [x] Closes #6806 - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [x] What's new entry - [x] Refer to PR ID (cannot be done before the PR has been created) - [x] New functions/methods are listed in `api.rst` - No new functions/methods. ## Motive Refer to #8698 for history In this PR more specifically: - Added a global option, `arithmetic_broadcast`, `=True` by default (current state) - If `arithmetic_broadcast=False` , [`_binary_op`](https://github.com/pydata/xarray/pull/8784/files#diff-43c76e9be8425b5b6897dcecab4b240c32580447455c0c8c0b9b7fd84ce8a15dR2270) raises an error with message: ``` arithmetic broadcast is disabled via global option ``` ## Unrelated Also adds a decorator to handle the optional dependency `dask_expr` 2024-02-25T14:00:57Z 2024-03-13T15:36:34Z 2024-03-13T15:36:34Z 2024-03-13T15:36:34Z 11f89ecdd41226cf93da8d1e720d2710849cd23e     0 d707a1b4bde192d0abec00fb6de194e423dc4c95 c919739fe6b2cdd46887dda90dcc50cb22996fe5 CONTRIBUTOR   xarray 13221727 https://github.com/pydata/xarray/pull/8784  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [pull_requests] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [state] TEXT,
   [locked] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [body] TEXT,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [merged_at] TEXT,
   [merge_commit_sha] TEXT,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [draft] INTEGER,
   [head] TEXT,
   [base] TEXT,
   [author_association] TEXT,
   [auto_merge] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [url] TEXT,
   [merged_by] INTEGER REFERENCES [users]([id])
);
CREATE INDEX [idx_pull_requests_merged_by]
    ON [pull_requests] ([merged_by]);
CREATE INDEX [idx_pull_requests_repo]
    ON [pull_requests] ([repo]);
CREATE INDEX [idx_pull_requests_milestone]
    ON [pull_requests] ([milestone]);
CREATE INDEX [idx_pull_requests_assignee]
    ON [pull_requests] ([assignee]);
CREATE INDEX [idx_pull_requests_user]
    ON [pull_requests] ([user]);
Powered by Datasette · Queries took 25.015ms · About: xarray-datasette
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows