home / github / pull_requests

Menu
  • Search all tables
  • GraphQL API

pull_requests: 1716494333

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
1716494333 PR_kwDOAMm_X85mT5_9 8719 closed 0 Test formatting platform 45271239 Follow up #8702 / https://github.com/pydata/xarray/pull/8702#issuecomment-1932851112 The goal is to remove the not elegant OS-dependant checks introduced during the testing of #8702 A simple way to do so is to use unsigned integer as dtypes for tests involving data array representations on multiple OSes. Indeed, this solves the issue of the default dtypes being not printed in the repr, with default dtyps varying according to the OS. The tests show that the concerned dtypes are `int32` (for the Windows CI) and `int64` (for Ubuntu and macOS CIs). Using `uint64` should fix both the varying size and the varying numpy array repr. ~~- [ ] Closes #xxxx~~ - [x] Tests added ~~- [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst`~~ ~~- [ ] New functions/methods are listed in `api.rst`~~ 2024-02-07T21:41:23Z 2024-02-09T03:01:35Z 2024-02-09T03:01:35Z 2024-02-09T03:01:35Z 0ad7fa78c6c883268030eef42fe0262bdd94af95     0 090894a6ba0306700d5bab151685b705427af651 97c8c18174a8354ced1d22b98d7a8c141c3f9c9d CONTRIBUTOR
{
    "enabled_by": {
        "login": "max-sixty",
        "id": 5635139,
        "node_id": "MDQ6VXNlcjU2MzUxMzk=",
        "avatar_url": "https://avatars.githubusercontent.com/u/5635139?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/max-sixty",
        "html_url": "https://github.com/max-sixty",
        "followers_url": "https://api.github.com/users/max-sixty/followers",
        "following_url": "https://api.github.com/users/max-sixty/following{/other_user}",
        "gists_url": "https://api.github.com/users/max-sixty/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/max-sixty/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/max-sixty/subscriptions",
        "organizations_url": "https://api.github.com/users/max-sixty/orgs",
        "repos_url": "https://api.github.com/users/max-sixty/repos",
        "events_url": "https://api.github.com/users/max-sixty/events{/privacy}",
        "received_events_url": "https://api.github.com/users/max-sixty/received_events",
        "type": "User",
        "site_admin": false
    },
    "merge_method": "squash",
    "commit_title": "Test formatting platform (#8719)",
    "commit_message": "* Test formatting platform\r\n\r\n* Default is float64\r\n\r\n* Try to differentiate between OS-dependant and independant dtypes for CI safety\r\n\r\n* wip\r\n\r\n* fixed tests\r\n\r\n* forgot one test\r\n\r\n---------\r\n\r\nCo-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>"
}
13221727 https://github.com/pydata/xarray/pull/8719  

Links from other tables

  • 0 rows from pull_requests_id in labels_pull_requests
Powered by Datasette · Queries took 0.817ms