issues

Table actions

3 rows where type = "pull" and user = 5700886 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 3 ✖

state 1

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
251734482 MDExOlB1bGxSZXF1ZXN0MTM2ODE1OTQ4 1514 Add `pathlib.Path` support to `open_(mf)dataset` willirath 5700886 closed 0     12 2017-08-21T18:21:34Z 2017-09-01T15:31:59Z 2017-09-01T15:31:52Z CONTRIBUTOR   0 pydata/xarray/pulls/1514
  • [x] Closes #799
  • [x] Tests added / passed
  • [x] Passes git diff upstream/master | flake8 --diff
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

This is meant to eventually make xarray.open_dataset and xarray.open_mfdataset work with pathlib.Path objects. I think this can be achieved as follows:

  1. In xarray.open_dataset, cast any pathlib.Path object to string

  2. In xarray.open_mfdataset, make sure to handle generators. This is necessary, because pathlib.Path('some-path').glob() returns generators.

Curently, tests with Python 2 are failing, because there is no explicit pathlib dependency yet.

With Python 3, everything seems to work. I am not happy with the tests I've added so far, though.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1514/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
251714595 MDExOlB1bGxSZXF1ZXN0MTM2ODAxMTk1 1513 WIP: Add pathlib support to `open_(mf)dataset` willirath 5700886 closed 0     1 2017-08-21T16:45:26Z 2017-08-21T17:33:49Z 2017-08-21T17:26:01Z CONTRIBUTOR   0 pydata/xarray/pulls/1513

This has #799 in mind.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1513/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
207011524 MDExOlB1bGxSZXF1ZXN0MTA1NzY5NTU1 1261 Allow for plotting dummy netCDF4.datetime objects. willirath 5700886 closed 0     9 2017-02-11T22:03:33Z 2017-03-09T21:43:54Z 2017-03-09T21:43:48Z CONTRIBUTOR   0 pydata/xarray/pulls/1261

Currently, xarray/plot.py raises a TypeError if the data to be plotted are not among [np.floating, np.integer, np.timedelta64, np.datetime64].

This PR adds netCDF4.datetime objects to the list of allowed data types. These occur, because xarray/conventions.py passes undecoded netCDF4.datetime objects if decoding to numpy.datetime64 fails. 

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1261/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);