issues: 251734482

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
251734482 MDExOlB1bGxSZXF1ZXN0MTM2ODE1OTQ4 1514 Add `pathlib.Path` support to `open_(mf)dataset` 5700886 closed 0     12 2017-08-21T18:21:34Z 2017-09-01T15:31:59Z 2017-09-01T15:31:52Z CONTRIBUTOR   0 pydata/xarray/pulls/1514
  • [x] Closes #799
  • [x] Tests added / passed
  • [x] Passes git diff upstream/master | flake8 --diff
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

This is meant to eventually make xarray.open_dataset and xarray.open_mfdataset work with pathlib.Path objects. I think this can be achieved as follows:

  1. In xarray.open_dataset, cast any pathlib.Path object to string

  2. In xarray.open_mfdataset, make sure to handle generators. This is necessary, because pathlib.Path('some-path').glob() returns generators.

Curently, tests with Python 2 are failing, because there is no explicit pathlib dependency yet.

With Python 3, everything seems to work. I am not happy with the tests I've added so far, though.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1514/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables