issues

Table actions

6 rows where type = "pull" and user = 221526 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 6 ✖

state 1

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
605920781 MDExOlB1bGxSZXF1ZXN0NDA4MjM3MjUz 3998 Fix handling of abbreviated units like msec dopplershift 221526 closed 0     3 2020-04-23T22:43:51Z 2020-04-24T19:18:00Z 2020-04-24T07:16:10Z CONTRIBUTOR   0 pydata/xarray/pulls/3998

By default, xarray tries to decode times with pandas and falls back to cftime. This fixes the exception handler to fallback properly in the cases an unhandled abbreviated unit is passed in.

An additional item here would be to add support for msec, etc. to xarray's handling, but I wasn't sure the best way to handle that. I'm happy just if things properly fall back to cftime.

  • [ ] Closes #xxxx
  • [x] Tests added
  • [x] Passes isort -rc . && black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3998/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
323823894 MDExOlB1bGxSZXF1ZXN0MTg4NTg4ODEy 2144 Add strftime() to datetime accessor dopplershift 221526 closed 0     13 2018-05-16T23:37:34Z 2020-04-23T22:40:41Z 2019-06-01T03:22:44Z CONTRIBUTOR   0 pydata/xarray/pulls/2144

This matches pandas and makes it possible to pass a datetime dataarray to something expecting to be able to use strftime().

  • [x] Closes #2090
  • [x] Tests added (for all bug fixes or enhancements)
  • [x] Tests passed (for all non-documentation changes)
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2144/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
501730864 MDExOlB1bGxSZXF1ZXN0MzIzOTQ4NTA1 3367 Remove setting of universal wheels dopplershift 221526 closed 0     4 2019-10-02T21:15:48Z 2019-10-05T20:05:58Z 2019-10-02T21:43:45Z CONTRIBUTOR   0 pydata/xarray/pulls/3367

Universal wheels indicate that one wheel supports Python 2 and 3. This is no longer the case for xarray. This causes builds to generate files with names like xarray-0.13.0-py2.py3-none-any.whl, which can cause pip to incorrectly install the wheel on Python 2 when installing from a list of wheel files.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3367/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
322019660 MDExOlB1bGxSZXF1ZXN0MTg3MjU4ODcx 2115 Fix docstring formatting for load(). dopplershift 221526 closed 0     1 2018-05-10T17:44:32Z 2018-05-10T18:24:04Z 2018-05-10T17:50:00Z CONTRIBUTOR   0 pydata/xarray/pulls/2115

Need '::' to introduce a code literal block. This was causing MetPy's doc build to warn (since we inherit AbstractDataStore).

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2115/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
308768432 MDExOlB1bGxSZXF1ZXN0MTc3NTkzMzUy 2016 Allow _FillValue and missing_value to differ (Fixes #1749) dopplershift 221526 closed 0     9 2018-03-26T23:20:10Z 2018-04-20T00:35:22Z 2018-03-31T01:16:00Z CONTRIBUTOR   0 pydata/xarray/pulls/2016

The CF standard permits both values, and them to have different values, so we should not be treating this as an error--just mask out all of them.

  • [x] Closes #1749 (remove if there is no corresponding issue, which should only be the case for minor changes)
  • [x] Tests added (for all bug fixes or enhancements)
  • [x] Tests passed (for all non-documentation changes)
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2016/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
250747314 MDExOlB1bGxSZXF1ZXN0MTM2MTEzMjA2 1508 ENH: Support using opened netCDF4.Dataset (Fixes #1459) dopplershift 221526 closed 0   0.10 2415632 5 2017-08-16T20:19:01Z 2017-08-31T22:24:36Z 2017-08-31T17:18:51Z CONTRIBUTOR   0 pydata/xarray/pulls/1508

Make the filename argument to NetCDF4DataStore polymorphic so that a Dataset can be passed in.

  • [x] Closes #1459
  • [x] Tests added / passed
  • [x] Passes git diff upstream/master | flake8 --diff
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

1459 discussed adding an alternate constructor (i.e. a class method) to NetCDF4DataStore to allow this, which would be my preferred approach rather than making a filename polymorphic (via isinstance). Unfortunately, alternate constructors only work by taking one set of parameters (or setting defaults) and then passing them to the original constructor. Given that, there's no way to make an alternate constructor without also making the original constructor somehow aware of this functionality--or breaking backwards-compatibility. I'm open to suggestions to the contrary.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1508/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);