issues: 250747314

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
250747314 MDExOlB1bGxSZXF1ZXN0MTM2MTEzMjA2 1508 ENH: Support using opened netCDF4.Dataset (Fixes #1459) 221526 closed 0   2415632 5 2017-08-16T20:19:01Z 2017-08-31T22:24:36Z 2017-08-31T17:18:51Z CONTRIBUTOR   0 pydata/xarray/pulls/1508

Make the filename argument to NetCDF4DataStore polymorphic so that a Dataset can be passed in.

  • [x] Closes #1459
  • [x] Tests added / passed
  • [x] Passes git diff upstream/master | flake8 --diff
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

1459 discussed adding an alternate constructor (i.e. a class method) to NetCDF4DataStore to allow this, which would be my preferred approach rather than making a filename polymorphic (via isinstance). Unfortunately, alternate constructors only work by taking one set of parameters (or setting defaults) and then passing them to the original constructor. Given that, there's no way to make an alternate constructor without also making the original constructor somehow aware of this functionality--or breaking backwards-compatibility. I'm open to suggestions to the contrary.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1508/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables