issues

Table actions

3 rows where state = "closed" and user = 7316393 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 2

state 1

  • closed · 3 ✖

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1503542001 I_kwDOAMm_X85Znjrx 7390 `Dataset` binary ops ignore `keep_attrs` option arongergely 7316393 closed 0     0 2022-12-19T20:20:41Z 2023-01-26T17:00:06Z 2023-01-26T17:00:06Z CONTRIBUTOR      

What is your issue?

When doing arithmetic operations on two Dataset operands, the keep_attrs=True option is ignored and therefore attributes not kept.

Minimal example:

```python import xarray as xr

ds1 = xr.Dataset( data_vars={"a": 1, "b": 1}, attrs={'my_attr': 'value'} ) ds2 = ds1.copy(deep=True)

with xr.set_options(keep_attrs=True): print(ds1 + ds2) `` This is not true for DataArrays/Variables which do takekeep_attrs` into account.

Proposed fix/improvement

Datasets to behave the same as DataArray/Variables, and keep attributes during binary operations when keep_attrs=True option is set.

PR is inbound.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7390/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed xarray 13221727 issue
1503573351 PR_kwDOAMm_X85F0O57 7391 Follow keep_attrs in Dataset binary ops arongergely 7316393 closed 0     9 2022-12-19T20:42:20Z 2023-01-26T17:00:04Z 2023-01-26T17:00:04Z CONTRIBUTOR   0 pydata/xarray/pulls/7391
  • [x] Closes #7390
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Should I describe in whats-new.rst?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7391/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1535425143 PR_kwDOAMm_X85Hfgpl 7445 Update description of `keep_attrs` parameter in documentation of `apply_ufunc()` arongergely 7316393 closed 0     1 2023-01-16T20:01:56Z 2023-01-17T10:32:36Z 2023-01-16T21:32:07Z CONTRIBUTOR   0 pydata/xarray/pulls/7445

Since #5041, apply_ufunc()'s keep_attrs parameter accepts combine_attrs-style strings. (First included v0.18.1 release) But this was not explained in its documentation.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7445/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);