issues: 1503542001

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1503542001 I_kwDOAMm_X85Znjrx 7390 `Dataset` binary ops ignore `keep_attrs` option 7316393 closed 0     0 2022-12-19T20:20:41Z 2023-01-26T17:00:06Z 2023-01-26T17:00:06Z CONTRIBUTOR      

What is your issue?

When doing arithmetic operations on two Dataset operands, the keep_attrs=True option is ignored and therefore attributes not kept.

Minimal example:

```python import xarray as xr

ds1 = xr.Dataset( data_vars={"a": 1, "b": 1}, attrs={'my_attr': 'value'} ) ds2 = ds1.copy(deep=True)

with xr.set_options(keep_attrs=True): print(ds1 + ds2) `` This is not true for DataArrays/Variables which do takekeep_attrs` into account.

Proposed fix/improvement

Datasets to behave the same as DataArray/Variables, and keep attributes during binary operations when keep_attrs=True option is set.

PR is inbound.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7390/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed 13221727 issue

Links from other tables