issues

Table actions

65 rows where state = "closed", type = "pull" and user = 43316012 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: comments, created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 65 ✖

state 1

  • closed · 65 ✖

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
2047459696 PR_kwDOAMm_X85iTmr2 8559 Support non-str Hashables in DataArray headtr1ck 43316012 closed 0     3 2023-12-18T21:09:13Z 2024-01-14T20:38:59Z 2024-01-14T20:38:59Z COLLABORATOR   0 pydata/xarray/pulls/8559
  • [x] Closes #8546
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Probably we should add a whole bunch of tests for this. For now only testing the constructor.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8559/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1914212923 PR_kwDOAMm_X85bRN9f 8234 Improved typing of align & broadcast headtr1ck 43316012 closed 0     1 2023-09-26T20:02:22Z 2023-12-18T20:28:03Z 2023-10-09T10:21:40Z COLLABORATOR   0 pydata/xarray/pulls/8234
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

This PR improves the typing of align. Before: the type of the inputs was reduced to the common superclass and the return type was the same. This often required casts or ignores when mixing classes (e.g. da, ds = xr.align(da, ds). Now: the return types are exactly the same as the input types if the number of passed arguments is <=5.

Only downside: it requires some ugly overloads with type ignores on align. Maybe someone knows how to type this better?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8234/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2021528727 PR_kwDOAMm_X85g7vZA 8502 change type of curvefit's p0 and bounds to mapping headtr1ck 43316012 closed 0     0 2023-12-01T20:18:19Z 2023-12-02T13:08:50Z 2023-12-01T22:02:38Z COLLABORATOR   0 pydata/xarray/pulls/8502
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Mini PR to improve the typing of curvefit. Using dict is problematic since it is invariant, while Mapping is covariant.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8502/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2021517557 PR_kwDOAMm_X85g7s9a 8501 Update to mypy1.7 headtr1ck 43316012 closed 0     1 2023-12-01T20:08:46Z 2023-12-02T13:08:45Z 2023-12-01T22:02:21Z COLLABORATOR   0 pydata/xarray/pulls/8501
  • [x] Closes #8448
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

I guess we update manually for now?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8501/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1827647823 PR_kwDOAMm_X85WuBEl 8030 Fix static typing with Matplotlib 3.8 headtr1ck 43316012 closed 0     14 2023-07-29T20:32:25Z 2023-09-26T19:01:29Z 2023-09-17T05:02:58Z COLLABORATOR   0 pydata/xarray/pulls/8030
  • [x] Closes #7802
  • [x] Tests added
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8030/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1897167470 PR_kwDOAMm_X85aX_Ms 8184 Fix several warnings in the tests headtr1ck 43316012 closed 0     1 2023-09-14T19:21:37Z 2023-09-26T19:01:13Z 2023-09-15T20:41:03Z COLLABORATOR   0 pydata/xarray/pulls/8184

Mainly deprecated "closed" argument in date_range and passing pd.MultiIndex directly to the constructor.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8184/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1901722232 PR_kwDOAMm_X85anII7 8204 Rewrite typed_ops headtr1ck 43316012 closed 0     5 2023-09-18T20:51:22Z 2023-09-26T19:00:49Z 2023-09-25T04:43:54Z COLLABORATOR   0 pydata/xarray/pulls/8204
  • [x] Related to #7780
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8204/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1620317764 PR_kwDOAMm_X85L1Yr2 7612 Fix `pcolormesh` with str coords headtr1ck 43316012 closed 0     4 2023-03-12T10:50:35Z 2023-09-13T18:48:08Z 2023-03-16T18:55:30Z COLLABORATOR   0 pydata/xarray/pulls/7612
  • [x] Closes #6775
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~New functions/methods are listed in api.rst~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7612/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1581313830 PR_kwDOAMm_X85Jy8wm 7523 allow refreshing of backends headtr1ck 43316012 closed 0     4 2023-02-12T16:07:05Z 2023-09-13T18:46:56Z 2023-03-31T15:14:56Z COLLABORATOR   0 pydata/xarray/pulls/7523
  • [x] Closes #7478
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] New functions/methods are listed in api.rst

Don't know yet how to effectively test this, I guess there is some tricky solution with some mocking.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7523/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1401132297 PR_kwDOAMm_X85AZG38 7142 Fix Codecov headtr1ck 43316012 closed 0     8 2022-10-07T12:55:00Z 2023-08-30T18:58:19Z 2023-08-30T18:47:33Z COLLABORATOR   0 pydata/xarray/pulls/7142
  • [x] Closes #7141
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7142/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1580266844 PR_kwDOAMm_X85JvlXi 7521 use numpys SupportsDtype headtr1ck 43316012 closed 0     11 2023-02-10T20:17:10Z 2023-03-18T14:08:20Z 2023-02-28T23:23:46Z COLLABORATOR   0 pydata/xarray/pulls/7521
  • [x] Closes #7479

I don't know how I feel about using private numpy classes that might change anytime. Maybe within a if TYPE_CHECKING block it is not too bad?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7521/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1620509524 PR_kwDOAMm_X85L19Mo 7616 add a test for scatter colorbar extend headtr1ck 43316012 closed 0     0 2023-03-12T20:58:45Z 2023-03-13T19:47:50Z 2023-03-13T19:47:50Z COLLABORATOR   0 pydata/xarray/pulls/7616
  • [x] Closes #4975
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7616/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1615980379 PR_kwDOAMm_X85Lm7SK 7600 Enable blacks `skip_magic_trailing_comma` options headtr1ck 43316012 closed 0     3 2023-03-08T21:36:46Z 2023-03-09T20:41:21Z 2023-03-09T20:40:25Z COLLABORATOR   0 pydata/xarray/pulls/7600

This little config change will make black remove trailing commas when they are not necessary to fit something into a single line.

It is a pure design choice but personally I like the clean up it does when function signatures simplify (although this happens rarely with more and more type hints added).

I can understand that some people prefer the manual control over what is multiline and what is not. Feel free to vote on it :)

For me it adds cheap LOCs so it looks like I am working hard, haha.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7600/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1503621596 PR_kwDOAMm_X85F0ZZm 7392 Support complex arrays in xr.corr headtr1ck 43316012 closed 0     2 2022-12-19T21:22:25Z 2023-03-02T20:22:54Z 2023-02-14T16:38:27Z COLLABORATOR   0 pydata/xarray/pulls/7392
  • [x] Closes #7340
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~New functions/methods are listed in api.rst~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7392/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1462057503 PR_kwDOAMm_X85DlALl 7315 Fix polyval overloads headtr1ck 43316012 closed 0     1 2022-11-23T16:27:21Z 2022-12-08T20:10:16Z 2022-11-26T15:42:51Z COLLABORATOR   0 pydata/xarray/pulls/7315
  • [x] Closes #7312
  • [ ] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~New functions/methods are listed in api.rst~

Turns out the default value of arguments is important for overloads, haha.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7315/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1377097243 PR_kwDOAMm_X84_J8JL 7051 Add parse_dims func headtr1ck 43316012 closed 0     6 2022-09-18T15:36:59Z 2022-12-08T20:10:01Z 2022-11-30T23:36:33Z COLLABORATOR   0 pydata/xarray/pulls/7051

This PR adds a utils.parse_dims function for parsing one or more dimensions. Currently every function that accepts multiple dimensions does this by itself.

I decided to first see if it would be useful to centralize the dimension parsing and collect inputs before adding it to other functions.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7051/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1421441672 PR_kwDOAMm_X85BcmP0 7209 Optimize some copying headtr1ck 43316012 closed 0     8 2022-10-24T21:00:21Z 2022-12-08T20:09:49Z 2022-11-30T23:36:56Z COLLABORATOR   0 pydata/xarray/pulls/7209
  • [x] Potentially closes #7181
  • [x] Tests added
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

I have passed along some more memo dicts, which could prevent some double deep-copying of the same data (don't know how exactly, but who knows :P) Also, I have found some copy calls that did not pass along the deep argument (I am not sure if that breaks things, lets find out). And finally I have found some places where shallow copies are enough.

All together it should improve the performance a lot when copying things around.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7209/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1468671915 PR_kwDOAMm_X85D65Bg 7335 Enable mypy warn unused ignores headtr1ck 43316012 closed 0     1 2022-11-29T20:42:08Z 2022-12-08T20:09:06Z 2022-12-01T16:14:07Z COLLABORATOR   0 pydata/xarray/pulls/7335

This PR adds the mypy option "warn_unused_ignores" which will raise an error if a # type: ignore is used where it is no longer necessary.

Should enable us to keep our types updated.

I am not sure if this will lead to many issues whenever e.g. numpy changes/improves their typing, so we might get errors whenever there is a new version. Maybe it is not that bad, or maybe we can also remove the option again and only do it manually from time to time?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7335/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1446613571 PR_kwDOAMm_X85Cw17l 7283 Fix mypy 0.990 types headtr1ck 43316012 closed 0     2 2022-11-12T21:34:14Z 2022-11-18T15:42:37Z 2022-11-16T18:41:58Z COLLABORATOR   0 pydata/xarray/pulls/7283
  • [x] Related to #7270
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7283/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1412019155 PR_kwDOAMm_X85A9Bge 7179 Lazy Imports headtr1ck 43316012 closed 0     13 2022-10-17T18:23:09Z 2022-11-16T23:32:21Z 2022-10-28T16:25:40Z COLLABORATOR   0 pydata/xarray/pulls/7179
  • [x] Hopefully Closes #6726
  • [x] ~Tests added~
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~New functions/methods are listed in api.rst~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7179/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
     xarray 13221727 pull
1424707135 PR_kwDOAMm_X85Bnixp 7228 Raise TypeError if plotting empty data headtr1ck 43316012 closed 0     3 2022-10-26T21:19:30Z 2022-11-10T23:00:42Z 2022-10-28T16:44:31Z COLLABORATOR   0 pydata/xarray/pulls/7228
  • [x] Closes #7156
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~New functions/methods are listed in api.rst~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7228/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1442702272 PR_kwDOAMm_X85Cjnvl 7276 Import nc_time_axis when needed headtr1ck 43316012 closed 0     2 2022-11-09T20:24:45Z 2022-11-10T23:00:15Z 2022-11-10T21:45:27Z COLLABORATOR   0 pydata/xarray/pulls/7276
  • [x] Closes #7275
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~New functions/methods are listed in api.rst~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7276/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1419882372 PR_kwDOAMm_X85BXXw0 7200 Backends descriptions headtr1ck 43316012 closed 0     3 2022-10-23T18:23:32Z 2022-10-26T19:45:15Z 2022-10-26T16:01:04Z COLLABORATOR   0 pydata/xarray/pulls/7200
  • [x] Closes #7049
  • [ ] Tests added
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] New functions/methods are listed in api.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7200/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1410498749 PR_kwDOAMm_X85A38a6 7168 Fix broken test that fails CI upstream headtr1ck 43316012 closed 0     1 2022-10-16T14:02:42Z 2022-10-17T17:48:07Z 2022-10-16T16:16:51Z COLLABORATOR   0 pydata/xarray/pulls/7168
  • [x] Closes #7158

Technically does not close all fails, but if we close it, the CI will open a new issue anyway and the discussion is not relevant anymore :)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7168/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1411110855 PR_kwDOAMm_X85A59Gg 7176 Add import ASV benchmark headtr1ck 43316012 closed 0     0 2022-10-17T08:11:58Z 2022-10-17T17:47:59Z 2022-10-17T15:25:18Z COLLABORATOR   0 pydata/xarray/pulls/7176 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7176/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1393482925 PR_kwDOAMm_X84__h6j 7113 Minor tests improvements headtr1ck 43316012 closed 0     0 2022-10-01T17:19:42Z 2022-10-16T13:56:28Z 2022-10-02T15:38:16Z COLLABORATOR   0 pydata/xarray/pulls/7113
  • silences some user warning from renaming dims.
  • fix coverage config
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7113/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1377128403 PR_kwDOAMm_X84_KB9v 7052 Add typing to plot methods headtr1ck 43316012 closed 0     32 2022-09-18T17:40:36Z 2022-10-16T13:54:26Z 2022-10-16T09:26:55Z COLLABORATOR   0 pydata/xarray/pulls/7052
  • [x] Closes #6949
  • [x] Tests added (typing)
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7052/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
     xarray 13221727 pull
1318808368 PR_kwDOAMm_X848JE7r 6834 Bump minimum numpy version to 1.20 headtr1ck 43316012 closed 0     18 2022-07-26T22:21:54Z 2022-10-12T21:49:49Z 2022-10-12T17:08:51Z COLLABORATOR   0 pydata/xarray/pulls/6834
  • [x] Closes #6818
  • [ ] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~~New functions/methods are listed in api.rst~~

Alternative to https://github.com/pydata/xarray/pull/6821

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6834/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1401013957 PR_kwDOAMm_X85AYtU2 7140 Fixes deepcopy of Index headtr1ck 43316012 closed 0     0 2022-10-07T11:18:10Z 2022-10-07T21:57:12Z 2022-10-07T21:57:12Z COLLABORATOR   0 pydata/xarray/pulls/7140

Forgot to add this to #7112

Also, correct the date of the 2022.09 release in whats-new, see #7135

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7140/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1393443839 PR_kwDOAMm_X84__aKC 7112 Support of repr and deepcopy of recursive arrays headtr1ck 43316012 closed 0     2 2022-10-01T15:24:40Z 2022-10-07T11:10:32Z 2022-10-06T22:04:01Z COLLABORATOR   0 pydata/xarray/pulls/7112
  • [x] Closes #7111
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

xarray.testing.assert_identical and probably more do not work yet.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7112/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1396832809 PR_kwDOAMm_X85AKhqW 7126 Upload mypy coverage report to codecov headtr1ck 43316012 closed 0     1 2022-10-04T20:55:02Z 2022-10-06T21:33:51Z 2022-10-06T20:38:14Z COLLABORATOR   0 pydata/xarray/pulls/7126

Not sure if that is the correct approach (to simply use a mypy flag) but lets see what people think about it.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7126/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1393837094 PR_kwDOAMm_X85AAmD9 7114 Fix typing of backends headtr1ck 43316012 closed 0     2 2022-10-02T17:20:56Z 2022-10-06T21:33:39Z 2022-10-06T21:30:01Z COLLABORATOR   0 pydata/xarray/pulls/7114

While adding type hints to test_backends I noticed that the open_dataset method and the abstract BackendEntrypoint were missing stream types as inputs.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7114/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1386709376 PR_kwDOAMm_X84_o-IX 7089 Fix deepcopy of Variables and DataArrays headtr1ck 43316012 closed 0     4 2022-09-26T20:54:16Z 2022-09-29T20:46:01Z 2022-09-29T16:36:51Z COLLABORATOR   0 pydata/xarray/pulls/7089
  • [x] Closes #2835 (Even though technically it fixes the DataArray version of the issue)
  • [x] ~~Tests added ~~ will be done via #7086
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

related to #2839

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7089/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1386664116 PR_kwDOAMm_X84_o0Jy 7087 Add typing to FacetGrid headtr1ck 43316012 closed 0     0 2022-09-26T20:16:26Z 2022-09-28T20:15:53Z 2022-09-28T18:30:59Z COLLABORATOR   0 pydata/xarray/pulls/7087

Mainly to annoy @Illviljan :)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7087/reactions",
    "total_count": 4,
    "+1": 1,
    "-1": 0,
    "laugh": 3,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1389764085 PR_kwDOAMm_X84_zMRw 7102 Exclude typechecking stuff from coverage headtr1ck 43316012 closed 0     1 2022-09-28T18:12:39Z 2022-09-28T20:15:52Z 2022-09-28T19:18:54Z COLLABORATOR   0 pydata/xarray/pulls/7102

tiny PR that disables coverage on types.py and all typing-only imports a.la. if TYPE_CHECKING: ...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7102/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1376479521 PR_kwDOAMm_X84_IJrz 7048 Add Ellipsis typehint to reductions headtr1ck 43316012 closed 0     8 2022-09-16T21:15:10Z 2022-09-28T18:02:51Z 2022-09-28T17:10:05Z COLLABORATOR   0 pydata/xarray/pulls/7048

This PR adds the ellipsis typehint to reductions (only where they behave differently from None to reduce overhead). Follow up on https://github.com/pydata/xarray/pull/7017#issuecomment-1243927061

Additionally I was changing a lot of "one or more dimensions" typehints to str | Iterable[Hashable] (See https://github.com/pydata/xarray/issues/6142). Some code changes were necessary to support this fully. Before several things were not working with actual hashable dimensions that are not strings.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7048/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1385143758 PR_kwDOAMm_X84_j6Bn 7080 Fix `utils.get_axis` with kwargs headtr1ck 43316012 closed 0     3 2022-09-25T19:50:15Z 2022-09-28T18:02:18Z 2022-09-28T17:11:16Z COLLABORATOR   0 pydata/xarray/pulls/7080
  • [x] Closes #7078
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~~New functions/methods are listed in api.rst~~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7080/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1368690120 PR_kwDOAMm_X84-uNM2 7017 Add Ellipsis typehints headtr1ck 43316012 closed 0     3 2022-09-10T17:53:26Z 2022-09-12T15:40:08Z 2022-09-11T13:40:07Z COLLABORATOR   0 pydata/xarray/pulls/7017

This PR adds an Ellipsis typehint to some functions.

Interestingly mypy did not complain at the tests before, I assume it is because "..." is Hashable or something like that?

I don't know what to do with reductions, since they also support ellipsis, but it is basically the same as using None. Therefore, I assume it is not necessary to expose this feature.

Did I miss any functions where ellipsis is supported? It is hard to look for "..."... xD

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7017/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1345227910 PR_kwDOAMm_X849gI4A 6939 Improve quantile method docstring + error headtr1ck 43316012 closed 0     1 2022-08-20T17:17:32Z 2022-09-10T09:03:05Z 2022-09-05T22:40:07Z COLLABORATOR   0 pydata/xarray/pulls/6939
  • [x] Closes #6875
  • [x] ~~Tests added~~
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~~New functions/methods are listed in api.rst~~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6939/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1362485455 PR_kwDOAMm_X84-Zfn0 6994 Even less warnings in tests headtr1ck 43316012 closed 0     2 2022-09-05T21:35:50Z 2022-09-10T09:02:46Z 2022-09-09T05:48:19Z COLLABORATOR   0 pydata/xarray/pulls/6994

This PR removes several warnings from the tests and improves their typing on the way.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6994/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1361262641 PR_kwDOAMm_X84-VY9P 6986 Remove some warnings in tests headtr1ck 43316012 closed 0     3 2022-09-04T21:58:57Z 2022-09-05T16:06:35Z 2022-09-05T10:52:45Z COLLABORATOR   0 pydata/xarray/pulls/6986

This PR tries to get rid of several warnings in the tests.

I could not get rid of RuntimeWarning: All-NaN slice encountered for tests with dask. Does anyone know why is that? pytest.mark.filterwarnings does not seem to capture them...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6986/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1345220697 PR_kwDOAMm_X849gHlT 6938 Fix bug where indexes were changed inplace headtr1ck 43316012 closed 0     1 2022-08-20T16:45:22Z 2022-08-22T11:07:46Z 2022-08-22T10:39:54Z COLLABORATOR   0 pydata/xarray/pulls/6938
  • [x] Closes #6931
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~~New functions/methods are listed in api.rst~~

Some typing on the way :)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6938/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1315959612 PR_kwDOAMm_X847_0k6 6821 Fix numpy 1.20 incompatibility headtr1ck 43316012 closed 0     8 2022-07-24T17:10:24Z 2022-08-20T17:01:13Z 2022-07-30T21:11:08Z COLLABORATOR   0 pydata/xarray/pulls/6821

This PR removes the _SupportsDType dependency from numpy and introduces its own.

Closes https://github.com/pydata/xarray/issues/6818

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6821/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1292091752 PR_kwDOAMm_X846vljd 6744 Fix `DataArrayRolling.__iter__` with `center=True` headtr1ck 43316012 closed 0     8 2022-07-02T16:36:00Z 2022-07-18T15:31:54Z 2022-07-14T17:41:01Z COLLABORATOR   0 pydata/xarray/pulls/6744
  • [x] Closes #6739
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~~New functions/methods are listed in api.rst~~

I have taken the freedom to move all rolling related tests into their own testing module. https://github.com/pydata/xarray/pull/6730 should then take care of the (by now) copy-pasted da and ds fixtures.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6744/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1261153511 PR_kwDOAMm_X845IYF5 6665 Update DataArray.rename + docu headtr1ck 43316012 closed 0     16 2022-06-05T20:32:57Z 2022-07-18T15:31:38Z 2022-07-18T14:48:02Z COLLABORATOR   0 pydata/xarray/pulls/6665
  • [x] Closes #5458
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

On the way, I have added the support for changing the name and dims/coords in the same rename call.

Also took the freedom to fix some unrelated typing problems.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6665/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1302461674 PR_kwDOAMm_X847SR33 6777 Move Rolling tests to their own testing module headtr1ck 43316012 closed 0     1 2022-07-12T18:20:58Z 2022-07-12T18:48:38Z 2022-07-12T18:46:32Z COLLABORATOR   0 pydata/xarray/pulls/6777

This PR moves all DataArrayRolling and DatasetRolling tests to their own module.

See request https://github.com/pydata/xarray/pull/6744#issuecomment-1182169308

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6777/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1292291988 PR_kwDOAMm_X846wMD8 6750 Add import change to whats-new headtr1ck 43316012 closed 0     0 2022-07-03T12:19:01Z 2022-07-12T18:09:40Z 2022-07-06T03:06:31Z COLLABORATOR   0 pydata/xarray/pulls/6750
  • [x] Closes #6741
  • [x] ~~Tests added~~
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~~New functions/methods are listed in api.rst~~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6750/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1275262097 PR_kwDOAMm_X8453Zo1 6702 Typing of GroupBy & Co. headtr1ck 43316012 closed 0     2 2022-06-17T16:50:43Z 2022-07-03T13:32:30Z 2022-06-29T20:06:04Z COLLABORATOR   0 pydata/xarray/pulls/6702

This PR adds typing support for groupby, coarsen, rolling, weighted and resample.

There are several open points:

  1. Coarsen is missing type annotations for reductions like max, they get added dynamically.
  2. The Groupby group-key type is quite wide. Does anyone have any idea on how to type it correctly? For now it is still Any.
  3. Several function signatures were inconsistent between the DataArray and Dataset versions (looking at you: map). I took the freedom to align them (required for mypy), hopefully this does not break too much.
  4. I was moving the generation functions from DataWithCoords to DataArray and Dataset, which adds some copy-paste of code (I tried to keep it minimal) but was unavoidable for typing support. (Adds the bonus that the corresponding modules are now only imported when required).
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6702/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1275993190 PR_kwDOAMm_X8455vDs 6706 Add `Dataset.dtypes` property headtr1ck 43316012 closed 0     7 2022-06-19T08:40:25Z 2022-06-26T08:08:21Z 2022-06-22T16:01:45Z COLLABORATOR   0 pydata/xarray/pulls/6706
  • [x] Closes #6714
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] New functions/methods are listed in api.rst

Currently returns a Mapping from variable names to dtypes for ALL variables in the Dataset, including coordinates. Possibly better to only return data_vars dtypes? Give me your thoughts on that, it is easy to change.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6706/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1278661854 PR_kwDOAMm_X846CnXr 6710 Expanduser (~) for open_dataset with dask headtr1ck 43316012 closed 0     2 2022-06-21T15:58:34Z 2022-06-26T08:08:04Z 2022-06-25T23:44:56Z COLLABORATOR   0 pydata/xarray/pulls/6710
  • [x] Closes #6707
  • [x] ~~Tests added~~
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

I don't really know how to test this... Is it ok to leave it untested?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6710/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1268697316 PR_kwDOAMm_X845hhHE 6690 Fix Dataset.where with drop=True and mixed dims headtr1ck 43316012 closed 0     3 2022-06-12T20:47:05Z 2022-06-13T18:06:44Z 2022-06-12T22:06:51Z COLLABORATOR   0 pydata/xarray/pulls/6690
  • [x] Closes #6227
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6690/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1243123406 PR_kwDOAMm_X844MH4t 6624 CFTime support for polyval headtr1ck 43316012 closed 0     7 2022-05-20T13:04:46Z 2022-06-04T10:18:14Z 2022-05-31T17:16:04Z COLLABORATOR   0 pydata/xarray/pulls/6624
  • [x] Closes #6623
  • [x] Tests added
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6624/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1251511305 PR_kwDOAMm_X844nz8j 6651 Typing support for custom backends headtr1ck 43316012 closed 0     4 2022-05-28T07:28:41Z 2022-06-04T10:17:55Z 2022-05-28T10:29:16Z COLLABORATOR   0 pydata/xarray/pulls/6651
  • [x] Closes #6632

So far we have not found a good way of typing dynamically added custom backends (installed via pip). So the only fallback option is to allow str.

I have decided to leave the Literal as type, since it gives the user a nice list of supported backends in the editor.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6651/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1260041574 PR_kwDOAMm_X845E39t 6661 Typing of Dataset headtr1ck 43316012 closed 0     4 2022-06-03T15:22:24Z 2022-06-04T10:17:48Z 2022-06-04T04:26:03Z COLLABORATOR   0 pydata/xarray/pulls/6661
  • [x] Closes #5945
  • [x] Tests added

Feel free to wait with merging after the 2022.05.0.dev0 release :)

  • This PR adds typing to all Dataset methods (only the ones in Dataset directly and DataWithCoords).
  • On the way it fixes several typing issues and adds small code changes for more consistent typing (hopefully does not break anything).
  • All test_dataset tests are now typed.
  • As usual there are still some mypy bugs open that prevent all typing changes to be final (especially https://github.com/python/mypy/issues/12846). I choose to remove the TypeVars in these occasions to prevent false positives on the user side.
  • Sorry for updating so many files at once, mostly these are the changes of adding from __future__ import annotations and automatic fixes from pyupdate.

If anyone has some typing expertise: I think that the way align is typed is wrong. The current implementation only works for aligning a sequence of objects of the same type, but not mixed DataArrays and Datasets. In some placed I had to add some "#type: ignore"s... I should probably open an issue for that.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6661/reactions",
    "total_count": 3,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 3,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1248463174 PR_kwDOAMm_X844drcZ 6637 Improved DataArray typing headtr1ck 43316012 closed 0     5 2022-05-25T17:54:54Z 2022-05-29T14:02:22Z 2022-05-27T16:03:10Z COLLABORATOR   0 pydata/xarray/pulls/6637
  • [x] Tests added

This PR improves typing of DataArray class methods. Main change is that T_DataArray is used whenever possible.

I have left everything untouched that would cause problems with mypy (there are some mypy bugs) or require larger typing efforts in other areas.

Main problems are argmin and argmax.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6637/reactions",
    "total_count": 3,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 3,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1244978704 PR_kwDOAMm_X844SHU7 6630 fix {full,zeros,ones}_like overloads headtr1ck 43316012 closed 0     0 2022-05-23T10:57:36Z 2022-05-27T06:32:37Z 2022-05-24T04:41:22Z COLLABORATOR   0 pydata/xarray/pulls/6630
  • [x] Closes #6628
  • [x] Tests added

forgot to add defaults to the dtype argument, so the typing defaulted back to the Union definition...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6630/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1249902974 PR_kwDOAMm_X844idGc 6641 Typing of `str` and `dt` accessors headtr1ck 43316012 closed 0     1 2022-05-26T18:25:44Z 2022-05-27T06:32:33Z 2022-05-26T20:12:23Z COLLABORATOR   0 pydata/xarray/pulls/6641

This is initial try to get type hints for str and dt accessors.

I think there is no way of accessing the class at class scope (or is there?), so I had to use plain "DataArray" as the generic type of the accessors. I think that is acceptable for now.

The hack of DatetimeAccessor vs TimedeltaAccessor in the CombinedDatetimelikeAccessor.__new__ is something static typing can handle, so at type-checking time all properties of both accessors are available. If someone has a better idea?

Maybe a common interface class for accessors would be also beneficial?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6641/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
     xarray 13221727 pull
1244082778 PR_kwDOAMm_X844PPS5 6626 Mypy badge headtr1ck 43316012 closed 0     1 2022-05-21T21:12:05Z 2022-05-22T13:56:45Z 2022-05-21T22:59:52Z COLLABORATOR   0 pydata/xarray/pulls/6626

This PR adds a mypy badge to the README.

Also, nicer alt texts for all other badges.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6626/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1236356209 PR_kwDOAMm_X8431neg 6612 Typing for open_dataset/array/mfdataset and to_netcdf/zarr headtr1ck 43316012 closed 0     5 2022-05-15T18:09:15Z 2022-05-19T16:08:07Z 2022-05-17T19:32:01Z COLLABORATOR   0 pydata/xarray/pulls/6612
  • [x] Closes #5382

Mypy is not able to compute the overloads of to_netcdf properly (too many Unions). I had to add some # type: ignore

I am not sure about the types of * concat_dim * combine_attrs: the Callable part is still with Anys

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6612/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1236316818 PR_kwDOAMm_X8431gAK 6611 {full,zeros,ones}_like typing headtr1ck 43316012 closed 0     2 2022-05-15T15:18:55Z 2022-05-16T18:10:05Z 2022-05-16T17:42:25Z COLLABORATOR   0 pydata/xarray/pulls/6611

(partial) typing for functions full_like, zeros_like, ones_like.

I could not figure out how to properly use TypeVars so many things are "hardcoded" with overloads.

I have added a DTypeLikeSave to npcompat, not sure that this file is supposed to be edited.

Problem1: TypeVar["T", Dataset, DataArray, Variable] can only be one of these three, but never with Union[Dataset, DataArray] which is used in several other places in xarray. Problem2: The official mypy support says: use TypeVar["T", bound=Union[Dataset, DataArray, Variable] but the the isinstance(obj, Dataset) could not be correctly resolved (is that a mypy issue?).

So if anyone can get it to work with TypeVars, feel free to change it. :)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6611/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1234229210 PR_kwDOAMm_X843u7hK 6601 change polyval dim ordering headtr1ck 43316012 closed 0     1 2022-05-12T16:30:44Z 2022-05-16T18:10:03Z 2022-05-12T19:01:59Z COLLABORATOR   0 pydata/xarray/pulls/6601
  • [x] Closes #6600
  • [x] Tests added
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6601/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1234135124 PR_kwDOAMm_X843unh4 6599 re-add timedelta support for polyval headtr1ck 43316012 closed 0     1 2022-05-12T15:12:41Z 2022-05-12T16:27:01Z 2022-05-12T15:43:29Z COLLABORATOR   0 pydata/xarray/pulls/6599
  • [x] Closes #6597
  • [x] Tests added
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6599/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1233058314 PR_kwDOAMm_X843rEkU 6593 Fix polyval overloads headtr1ck 43316012 closed 0     2 2022-05-11T18:54:54Z 2022-05-12T14:50:14Z 2022-05-11T19:42:41Z COLLABORATOR   0 pydata/xarray/pulls/6593

Attempt to fix the typing issues in xr.polyval.

Some problems are still occuring and require a type: ignore. They seem more like mypy issues to me.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6593/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1228977960 PR_kwDOAMm_X843dwXx 6579 Fix Dataset/DataArray.isel with drop=True and scalar DataArray indexes headtr1ck 43316012 closed 0     1 2022-05-08T20:17:04Z 2022-05-11T17:19:53Z 2022-05-10T06:18:19Z COLLABORATOR   0 pydata/xarray/pulls/6579
  • [x] Closes #6554
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Additionally I have added new literal types for error handling (Only applied to functions related to isel such that mypy stops complaining).

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6579/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1221848774 PR_kwDOAMm_X843HV4r 6548 polyval: Use Horner's algorithm + support chunked inputs headtr1ck 43316012 closed 0     13 2022-04-30T14:50:53Z 2022-05-05T19:33:53Z 2022-05-05T19:15:58Z COLLABORATOR   0 pydata/xarray/pulls/6548
  • [x] Closes #6526, #6411
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6548/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);