issues: 1914212923

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1914212923 PR_kwDOAMm_X85bRN9f 8234 Improved typing of align & broadcast 43316012 closed 0     1 2023-09-26T20:02:22Z 2023-12-18T20:28:03Z 2023-10-09T10:21:40Z COLLABORATOR   0 pydata/xarray/pulls/8234
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

This PR improves the typing of align. Before: the type of the inputs was reduced to the common superclass and the return type was the same. This often required casts or ignores when mixing classes (e.g. da, ds = xr.align(da, ds). Now: the return types are exactly the same as the input types if the number of passed arguments is <=5.

Only downside: it requires some ugly overloads with type ignores on align. Maybe someone knows how to type this better?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8234/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables