home / github

Menu
  • Search all tables
  • GraphQL API

issues

Table actions
  • GraphQL API for issues

8 rows where state = "closed", type = "pull" and user = 39069044 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: comments, created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 8 ✖

state 1

  • closed · 8 ✖

repo 1

  • xarray 8
id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
2171912634 PR_kwDOAMm_X85o3Ify 8809 Pass variable name to `encode_zarr_variable` slevang 39069044 closed 0     6 2024-03-06T16:21:53Z 2024-04-03T14:26:49Z 2024-04-03T14:26:48Z CONTRIBUTOR   0 pydata/xarray/pulls/8809
  • [x] Closes https://github.com/xarray-contrib/xeofs/issues/148
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

The change from https://github.com/pydata/xarray/pull/8672 mostly fixed the issue of serializing a reset multiindex in the backends, but there was an additional niche issue that turned up in xeofs that was causing serialization to still fail on the zarr backend.

The issue is that zarr is the only backend that uses a custom version of encode_cf_variable called encode_zarr_variable, and the way this gets called we don't pass through the name of the variable before running ensure_not_multiindex.

As a minimal fix, this PR just passes name through as an additional arg to the general encode_variable function. See @benbovy's comment that maybe we should actually unwrap the level coordinate in reset_index and clean up the checks in ensure_not_multiindex, but I wasn't able to get that working easily.

The exact workflow this turned up in involves DataTree and looks like this: ```python import numpy as np import xarray as xr from datatree import DataTree

ND DataArray that gets stacked along a multiindex

da = xr.DataArray(np.ones((3, 3)), coords={"dim1": [1, 2, 3], "dim2": [4, 5, 6]}) da = da.stack(feature=["dim1", "dim2"])

Extract just the stacked coordinates for saving in a dataset

ds = xr.Dataset(data_vars={"feature": da.feature})

Reset the multiindex, which should make things serializable

ds = ds.reset_index("feature") dt1 = DataTree() dt2 = DataTree(name="feature", data=ds) dt1["foo"] = dt2

Somehow in this step, dt1.foo.feature.dim1.variable becomes an IndexVariable again

print(type(dt1.foo.feature.dim1.variable))

Works

dt1.to_netcdf("test.nc", mode="w")

Fails

dt1.to_zarr("test.zarr", mode="w") ```

But we can reproduce in xarray with the test added here.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8809/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    xarray 13221727 pull
1985969769 PR_kwDOAMm_X85fDaBX 8434 Automatic region detection and transpose for `to_zarr()` slevang 39069044 closed 0     15 2023-11-09T16:15:08Z 2023-11-14T18:34:50Z 2023-11-14T18:34:50Z CONTRIBUTOR   0 pydata/xarray/pulls/8434
  • [x] Closes #7702, #8421
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

A quick pass at implementing these two improvements for zarr region writes:

  1. allow passing region={dim: "auto"}, which opens the existing zarr store and identifies the correct slice to write to, using a variation of the approach suggested by @DahnJ here. We also check for non-matching coordinates and non-contiguous indices.
  2. automatically transpose dimensions if they otherwise match the existing store but are out of order
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8434/reactions",
    "total_count": 3,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 3,
    "rocket": 0,
    "eyes": 0
}
    xarray 13221727 pull
1483235066 PR_kwDOAMm_X85Eti0b 7364 Handle numpy-only attrs in `xr.where` slevang 39069044 closed 0     1 2022-12-08T00:52:43Z 2022-12-10T21:52:49Z 2022-12-10T21:52:37Z CONTRIBUTOR   0 pydata/xarray/pulls/7364
  • [x] Closes #7362
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7364/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    xarray 13221727 pull
1424732975 PR_kwDOAMm_X85Bnoaj 7229 Fix coordinate attr handling in `xr.where(..., keep_attrs=True)` slevang 39069044 closed 0     5 2022-10-26T21:45:01Z 2022-11-30T23:35:29Z 2022-11-30T23:35:29Z CONTRIBUTOR   0 pydata/xarray/pulls/7229
  • [x] Closes #7220
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Reverts the getattr method used in xr.where(..., keep_attrs=True) from #6461, but keeps handling for scalar inputs. Adds some test cases to ensure consistent attribute handling.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7229/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    xarray 13221727 pull
1198058137 PR_kwDOAMm_X8416DPB 6461 Fix `xr.where(..., keep_attrs=True)` bug slevang 39069044 closed 0     4 2022-04-09T03:02:40Z 2022-10-25T22:40:15Z 2022-04-12T02:12:39Z CONTRIBUTOR   0 pydata/xarray/pulls/6461
  • [x] Closes #6444
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Fixes a bug introduced by #4687 where passing a non-xarray object to x in xr.where(cond, x, y, keep_attrs=True) caused a failure. The keep_attrs callable passed to merge_attrs() tries to access the attributes of x which do not exist in this case. This fix just checks to make sure x has attributes, and if not will pass through keep_attrs=True.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6461/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    xarray 13221727 pull
1381297782 PR_kwDOAMm_X84_XseG 7063 Better dtype preservation for rolling mean on dask array slevang 39069044 closed 0     1 2022-09-21T17:59:07Z 2022-09-22T22:06:08Z 2022-09-22T22:06:08Z CONTRIBUTOR   0 pydata/xarray/pulls/7063
  • [x] Closes #7062
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

This just tests to make sure we at least get the same dtype whether we have a numpy or dask array.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7063/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    xarray 13221727 pull
1380016376 PR_kwDOAMm_X84_TlHf 7060 More informative error for non-existent zarr store slevang 39069044 closed 0     2 2022-09-20T21:27:35Z 2022-09-20T22:38:45Z 2022-09-20T22:38:45Z CONTRIBUTOR   0 pydata/xarray/pulls/7060
  • [x] Closes #6484
  • [x] Tests added

I've often been tripped up by the stack trace noted in #6484. This PR changes two things:

  1. Handles the zarr GroupNotFoundError error with a more informative FileNotFoundError, displaying the path where we didn't find a zarr store.
  2. Moves the consolidated metadata warning to after the step of successfully opening the zarr with non-consolidated metadata. This way the warning isn't shown if we are actually trying to open a non-existent zarr store, in which case we only get the error above and no warning.
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7060/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    xarray 13221727 pull
797302408 MDExOlB1bGxSZXF1ZXN0NTY0MzM0ODQ1 4849 Basic curvefit implementation slevang 39069044 closed 0     12 2021-01-30T01:28:16Z 2021-03-31T16:55:53Z 2021-03-31T16:55:53Z CONTRIBUTOR   0 pydata/xarray/pulls/4849
  • [x] Closes #4300
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] New functions/methods are listed in api.rst

This is a simple implementation of a more general curve-fitting API as discussed in #4300, using the existing scipy curve_fit functionality wrapped with apply_ufunc. It works for arbitrary user-supplied 1D functions that ingest numpy arrays. Formatting and nomenclature of the outputs was largely copied from .polyfit, but could probably be improved.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4849/reactions",
    "total_count": 5,
    "+1": 4,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);
Powered by Datasette · Queries took 1128.788ms · About: xarray-datasette