issues: 1198058137

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1198058137 PR_kwDOAMm_X8416DPB 6461 Fix `xr.where(..., keep_attrs=True)` bug 39069044 closed 0     4 2022-04-09T03:02:40Z 2022-10-25T22:40:15Z 2022-04-12T02:12:39Z CONTRIBUTOR   0 pydata/xarray/pulls/6461
  • [x] Closes #6444
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Fixes a bug introduced by #4687 where passing a non-xarray object to x in xr.where(cond, x, y, keep_attrs=True) caused a failure. The keep_attrs callable passed to merge_attrs() tries to access the attributes of x which do not exist in this case. This fix just checks to make sure x has attributes, and if not will pass through keep_attrs=True.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6461/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables