issues

Table actions

3 rows where repo = 13221727, type = "pull" and user = 296686 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 3 ✖

state 1

repo 1

  • xarray · 3 ✖
id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
348462356 MDExOlB1bGxSZXF1ZXN0MjA2ODA3Mjkz 2351 Remove redundant code from open_rasterio and ensure all transform tuples are six elements long robintw 296686 closed 0     2 2018-08-07T19:48:39Z 2018-08-13T22:34:18Z 2018-08-13T22:33:54Z CONTRIBUTOR   0 pydata/xarray/pulls/2351
  • [x] Closes #2348
  • [x] Tests added (for all bug fixes or enhancements)
  • [x] Tests passed (for all non-documentation changes)
  • [ ] Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

This removes the redundant code that ended up with the transform attribute being set twice - and being set to a nine-element long tuple rather than the correct six-element long tuple. It also adds tests to ensure that all transform attributes are six-element-long tuples.

I haven't made any changes to the documentation, as I wasn't sure if it was needed. This could potentially affect users as the documentation and the code differed and people may have written other interface code (as, in my case, code to export a DataArray to a GeoTIFF using rasterio) which relies on the transform element having 9 elements rather than the 6 it is meant to have. Any thoughts?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2351/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
173632183 MDExOlB1bGxSZXF1ZXN0ODMwMDc3MzY= 990 Added convenience method for saving DataArray to netCDF file robintw 296686 closed 0     17 2016-08-28T06:30:32Z 2016-09-06T04:00:25Z 2016-09-06T04:00:06Z CONTRIBUTOR   0 pydata/xarray/pulls/990

Added a simple function to DataArray that creates a dataset with one variable called 'data' and then saves it to a netCDF file. All parameters are passed through to to_netcdf().

Added an equivalent function called open_dataarray to be used to load from these files.

Fixes #915.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/990/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
173640823 MDExOlB1bGxSZXF1ZXN0ODMwMTI0MzE= 991 Added validation of attrs before saving to netCDF files robintw 296686 closed 0     6 2016-08-28T11:01:18Z 2016-09-02T22:52:09Z 2016-09-02T22:52:04Z CONTRIBUTOR   0 pydata/xarray/pulls/991

This allows us to give nice errors if users try to save a Dataset with attr values that can't be written to a netCDF file.

Fixes #911.

I've added tests to test_backends.py as I can't see a better place to put them. I've also made the tests fairly extensive, but also used some helper functions to stop too much repetition. Please let me know if any of this doesn't fit within the xarray style.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/991/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);