issues

Table actions

8 rows where comments = 7, type = "pull" and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 8 ✖

state 1

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1899109828 PR_kwDOAMm_X85aeino 8193 Add some more mypy checks max-sixty 5635139 closed 0     7 2023-09-15T21:40:14Z 2023-09-17T19:34:55Z 2023-09-17T19:24:58Z MEMBER   0 pydata/xarray/pulls/8193

This disallows redundant casts

FWIW I thought we had gone through many of the tests and forced them to have typed defs, maybe with the intention of turning on some elements of strict mode. But then I don't think we have any strictness checks at the moment, and I see many functions in the tests which don't have typing. Am I mis-rembering?? Or maybe we started but didn't get far enough (it is a big project...)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8193/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
994264727 MDExOlB1bGxSZXF1ZXN0NzMyMjM5NjEw 5787 Update issue template to include a checklist max-sixty 5635139 closed 0     7 2021-09-12T19:47:23Z 2022-04-27T08:23:27Z 2022-04-27T00:56:27Z MEMBER   0 pydata/xarray/pulls/5787

This may be overly prescriptive. We've had a number of recent issues which aren't minimal and link to external data, and then these languish on the Issue Tracker unanswered. That's a loss of time for all involved — the reporter of the issue as well as the maintainers.

To the extent we can predict which issues will languish, it would be better to give that guidance up front, and encourage examples which are easier to engage with. So this introduces a checklist that people need to proactively fill out.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5787/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
777586739 MDExOlB1bGxSZXF1ZXN0NTQ3ODQxNzk4 4753 Replace SortedKeysDict with dict max-sixty 5635139 closed 0     7 2021-01-03T07:02:39Z 2021-05-19T19:30:19Z 2021-05-19T19:29:31Z MEMBER   0 pydata/xarray/pulls/4753
  • [x] Tests added
  • [x] Passes isort . && black . && mypy . && flake8
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Inspired by @mathause research in https://github.com/pydata/xarray/issues/4571#issuecomment-724848270

Note that one test is removed: https://github.com/pydata/xarray/compare/master...max-sixty:sorted-keys?expand=1#diff-2db7f6624707083db4aaab1b62eb11352200ec9d3ac1055de84877912226d7b5L560

While I'm keen on simplifying the data structures, this may have some unforeseen consequences, and at least deserves some thought re how we handle differently ordered dims.

Currently this PR retains the sorting in reprs.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4753/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
705050342 MDExOlB1bGxSZXF1ZXN0NDg5ODYwODEx 4440 Add doctests to release notes max-sixty 5635139 closed 0     7 2020-09-20T05:39:51Z 2020-09-20T21:24:18Z 2020-09-20T19:33:36Z MEMBER   0 pydata/xarray/pulls/4440

Any other changes?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4440/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
514142439 MDExOlB1bGxSZXF1ZXN0MzMzODA1NTUy 3459 Dataset.map max-sixty 5635139 closed 0     7 2019-10-29T18:46:04Z 2019-11-09T22:08:07Z 2019-11-09T21:10:23Z MEMBER   0 pydata/xarray/pulls/3459

This is the first step towards organizing these functions a bit better, as outlined in https://github.com/pydata/xarray/issues/1251, https://github.com/pydata/xarray/issues/1618, https://github.com/pydata/xarray/pull/2674

While this one is a fairly easy decision, others are going to be harder. Open to a more methodical up-front process before we start making changes, if we think that's necessary.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3459/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
514164837 MDExOlB1bGxSZXF1ZXN0MzMzODI0ODMx 3460 fix test suite warnings re `drop` max-sixty 5635139 closed 0     7 2019-10-29T19:24:03Z 2019-10-31T04:39:11Z 2019-10-31T01:24:16Z MEMBER   0 pydata/xarray/pulls/3460

Some more warnings silenced

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3460/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
478690528 MDExOlB1bGxSZXF1ZXN0MzA1NzUxMzc0 3194 Remove future statements max-sixty 5635139 closed 0     7 2019-08-08T21:14:35Z 2019-08-09T04:33:11Z 2019-08-09T04:33:08Z MEMBER   0 pydata/xarray/pulls/3194

Not sure why these weren't picked up in some of the previous python3-ifying

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3194/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
448295143 MDExOlB1bGxSZXF1ZXN0MjgyMTEyOTQ4 2987 Implement @ operator for DataArray max-sixty 5635139 closed 0     7 2019-05-24T18:14:20Z 2019-06-01T20:00:24Z 2019-06-01T19:42:21Z MEMBER   0 pydata/xarray/pulls/2987

Is it really this easy? What am I missing?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2987/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);