home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 777586739

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
777586739 MDExOlB1bGxSZXF1ZXN0NTQ3ODQxNzk4 4753 Replace SortedKeysDict with dict 5635139 closed 0     7 2021-01-03T07:02:39Z 2021-05-19T19:30:19Z 2021-05-19T19:29:31Z MEMBER   0 pydata/xarray/pulls/4753
  • [x] Tests added
  • [x] Passes isort . && black . && mypy . && flake8
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Inspired by @mathause research in https://github.com/pydata/xarray/issues/4571#issuecomment-724848270

Note that one test is removed: https://github.com/pydata/xarray/compare/master...max-sixty:sorted-keys?expand=1#diff-2db7f6624707083db4aaab1b62eb11352200ec9d3ac1055de84877912226d7b5L560

While I'm keen on simplifying the data structures, this may have some unforeseen consequences, and at least deserves some thought re how we handle differently ordered dims.

Currently this PR retains the sorting in reprs.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4753/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 1 row from issues_id in issues_labels
  • 7 rows from issue in issue_comments
Powered by Datasette · Queries took 0.582ms · About: xarray-datasette