issues

Table actions

7 rows where comments = 6, type = "pull" and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 7 ✖

state 1

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1878288525 PR_kwDOAMm_X85ZYos5 8139 Fix pandas' `interpolate(fill_value=)` error max-sixty 5635139 closed 0     6 2023-09-02T02:41:45Z 2023-09-28T16:48:51Z 2023-09-04T18:05:14Z MEMBER   0 pydata/xarray/pulls/8139

Pandas no longer has a fill_value parameter for interpolate.

Weirdly I wasn't getting this locally, on pandas 2.1.0, only in CI on https://github.com/pydata/xarray/actions/runs/6054400455/job/16431747966?pr=8138.

Removing it passes locally, let's see whether this works in CI

Would close #8125 

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8139/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
967854972 MDExOlB1bGxSZXF1ZXN0NzEwMDA1NzY4 5694 Ask PRs to annotate tests max-sixty 5635139 closed 0     6 2021-08-12T02:19:28Z 2023-09-28T16:46:19Z 2023-06-19T05:46:36Z MEMBER   0 pydata/xarray/pulls/5694
  • [x] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

As discussed https://github.com/pydata/xarray/pull/5690#issuecomment-897280353

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5694/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
729208432 MDExOlB1bGxSZXF1ZXN0NTA5NzM0NTM2 4540 numpy_groupies max-sixty 5635139 closed 0     6 2020-10-26T03:37:19Z 2022-02-05T22:24:12Z 2021-10-24T00:18:52Z MEMBER   0 pydata/xarray/pulls/4540
  • [x] Closes https://github.com/pydata/xarray/issues/4473
  • [ ] Tests added
  • [x] Passes isort . && black . && mypy . && flake8
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [ ] New functions/methods are listed in api.rst

Very early effort — I found this harder than I expected — I was trying to use the existing groupby infra, but think I maybe should start afresh. The result of the numpy_groupies operation is a fully formed array, whereas we're used to handling an iterable of results which need to be concat.

I also added some type signature / notes and I was going through the existing code; mostly for my own understanding

If anyone has any thoughts, feel free to comment — otherwise I'll resume this soon

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4540/reactions",
    "total_count": 4,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 2,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
399164733 MDExOlB1bGxSZXF1ZXN0MjQ0NjU3NTk5 2674 Skipping variables in datasets that don't have the core dim max-sixty 5635139 closed 0     6 2019-01-15T02:43:11Z 2021-05-13T22:02:19Z 2021-05-13T22:02:19Z MEMBER   0 pydata/xarray/pulls/2674

ref https://github.com/pydata/xarray/pull/2650#issuecomment-454164295

This seems an ugly way of accomplishing the goal; any ideas for a better way of doing this?

And stepping back, do others think a) it's helpful to skip variables in a dataset, and b) apply_ufunc should do this?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2674/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
575088962 MDExOlB1bGxSZXF1ZXN0MzgzMzAwMjgw 3826 Allow ellipsis to be used in stack max-sixty 5635139 closed 0     6 2020-03-04T02:21:21Z 2020-03-20T01:20:54Z 2020-03-19T22:55:09Z MEMBER   0 pydata/xarray/pulls/3826 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3826/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
577283480 MDExOlB1bGxSZXF1ZXN0Mzg1MTA3OTU4 3846 Doctests fixes max-sixty 5635139 closed 0     6 2020-03-07T05:44:27Z 2020-03-10T14:03:05Z 2020-03-10T14:03:00Z MEMBER   0 pydata/xarray/pulls/3846
  • [ ] Closes #xxxx
  • [ ] Tests added
  • [x] Passes isort -rc . && black . && mypy . && flake8
  • [ ] Fully documented, including whats-new.rst for all changes and api.rst for new API

Starting to get some fixes in.

It's going to be a long journey though. I think maybe we whitelist some files and move gradually through before whitelisting the whole library.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3846/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
457080809 MDExOlB1bGxSZXF1ZXN0Mjg4OTY1MzQ4 3029 Fix pandas-dev tests max-sixty 5635139 closed 0     6 2019-06-17T18:15:16Z 2019-06-28T15:31:33Z 2019-06-28T15:31:28Z MEMBER   0 pydata/xarray/pulls/3029

Currently pandas-dev tests get 'stuck' on the conda install. The last instruction to run is the standard install:

$ if [[ "$CONDA_ENV" == "docs" ]]; then conda env create -n test_env --file doc/environment.yml; elif [[ "$CONDA_ENV" == "lint" ]]; then conda env create -n test_env --file ci/requirements-py37.yml; else conda env create -n test_env --file ci/requirements-$CONDA_ENV.yml; fi

And after installing the libraries, it prints this and then stops:

Preparing transaction: - - done Verifying transaction: | / \ | / - \ | / / done Executing transaction: \ | / - \ | / - \ | / - \ | / - \ | / - \ | / / - \ | / - \ done No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

I'm not that familiar with conda. Anyone have any ideas as to why this would fail while the other builds would succeed?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3029/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);