issues

Table actions

47 rows where comments = 2, type = "pull" and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: draft, created_at (date), updated_at (date), closed_at (date)

state 2

type 1

  • pull · 47 ✖

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
2262478932 PR_kwDOAMm_X85tqpUi 8974 Raise errors on new warnings from within xarray max-sixty 5635139 closed 0     2 2024-04-25T01:50:48Z 2024-04-29T12:18:42Z 2024-04-29T02:50:21Z MEMBER   0 pydata/xarray/pulls/8974

Notes are inline.

Done with some help from an LLM — quite good for doing tedious tasks that we otherwise wouldn't want to do — can paste in all the warnings output and get a decent start on rules for exclusions

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8974/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2033367994 PR_kwDOAMm_X85hj9np 8533 Offer a fixture for unifying DataArray & Dataset tests max-sixty 5635139 closed 0     2 2023-12-08T22:06:28Z 2023-12-18T21:30:41Z 2023-12-18T21:30:40Z MEMBER   0 pydata/xarray/pulls/8533

Some tests are literally copy & pasted between DataArray & Dataset tests. This change allows them to use a single test. Not everything will be able to use this — sometimes we want to check specifics — but some will — I've change the .cumulative tests to use this fixture.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8533/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2021810083 PR_kwDOAMm_X85g8r6c 8508 Implement `np.clip` as `__array_function__` max-sixty 5635139 closed 0     2 2023-12-02T02:20:11Z 2023-12-03T05:27:38Z 2023-12-03T05:27:33Z MEMBER   0 pydata/xarray/pulls/8508

Would close https://github.com/pydata/xarray/issues/2570

Because of https://numpy.org/neps/nep-0018-array-function-protocol.html#partial-implementation-of-numpy-s-api, no option is ideal: - Don't do anything — don't implement __array_function__. Any numpy function that's not a ufunc — such as np.clip will materialize the array into memory. - Implement __array_function__ and lose the ability to call any non-ufunc-numpy-func that we don't explicitly configure here. So np.lexsort(da) wouldn't work, for example; and users would have to run np.lexsort(da.values). - Implement __array_function__, and attempt to handle the functions we don't explicitly configure by coercing to numpy arrays. This requires writing code to walk a tree of objects looking for arrays to coerce. It seems to go against the original numpy proposal.

@shoyer is this summary accurate?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8508/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1964877168 PR_kwDOAMm_X85d8EmN 8381 Allow writing to zarr with differently ordered dims max-sixty 5635139 closed 0     2 2023-10-27T06:47:59Z 2023-11-25T21:02:20Z 2023-11-15T18:09:08Z MEMBER   0 pydata/xarray/pulls/8381

Is this reasonable?

  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8381/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2000154383 PR_kwDOAMm_X85fzju6 8466 Move Sphinx directives out of `See also` max-sixty 5635139 open 0     2 2023-11-18T01:57:17Z 2023-11-21T18:25:05Z   MEMBER   0 pydata/xarray/pulls/8466

This is potentially causing the See also to not render the links? (Does anyone know this better? It doesn't seem easy to build the docs locally...)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8466/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
400444797 MDExOlB1bGxSZXF1ZXN0MjQ1NjMwOTUx 2687 Enable resampling on PeriodIndex max-sixty 5635139 closed 0     2 2019-01-17T20:13:25Z 2023-11-17T20:38:44Z 2023-11-17T20:38:44Z MEMBER   0 pydata/xarray/pulls/2687

This allows resampling with PeriodIndex objects by keeping the group as an index rather than coercing to a DataArray (which coerces any non-native types to objects)

I'm still getting one failure around the name of the IndexVariable still being __resample_dim__ after resample, but wanted to socialize the approach of allowing a name argument to IndexVariable - is this reasonable?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2687/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1986758555 PR_kwDOAMm_X85fGE95 8438 Rename `to_array` to `to_dataarray` max-sixty 5635139 closed 0     2 2023-11-10T02:58:21Z 2023-11-10T06:15:03Z 2023-11-10T06:15:02Z MEMBER   0 pydata/xarray/pulls/8438

This is a very minor nit, so I'm not sure it's worth changing.

What do others think?

(I would have opened an issue but it's just as quick to just do the PR)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8438/reactions",
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1931582554 PR_kwDOAMm_X85cLpap 8285 Add `min_weight` param to `rolling_exp` functions max-sixty 5635139 closed 0     2 2023-10-08T01:09:59Z 2023-10-14T07:24:48Z 2023-10-14T07:24:48Z MEMBER   0 pydata/xarray/pulls/8285   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8285/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1916391948 PR_kwDOAMm_X85bYlaM 8242 Add modules to `check-untyped` max-sixty 5635139 closed 0     2 2023-09-27T21:56:45Z 2023-09-29T17:43:07Z 2023-09-29T16:39:34Z MEMBER   0 pydata/xarray/pulls/8242

In reviewing https://github.com/pydata/xarray/pull/8241, I realize that we actually want check-untyped-defs, which is a bit less strict, but lets us add some more modules on. I did have to add a couple of ignores, think it's a reasonable tradeoff to add big modules like computation on.

Errors with this enabled are actual type errors, not just mypy pedanticness, so would be good to get as much as possible into this list...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8242/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1459938761 PR_kwDOAMm_X85DdsG- 7311 Add numba to nightly upstream max-sixty 5635139 closed 0     2 2022-11-22T14:04:54Z 2023-09-28T16:48:16Z 2023-01-15T18:07:48Z MEMBER   0 pydata/xarray/pulls/7311

I saw that we didn't have this while investigating https://github.com/numba/numba/issues/8615. We should probably wait until that's resolved before merging this (this doesn't solve that issue).

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7311/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
430194200 MDExOlB1bGxSZXF1ZXN0MjY4MTM4OTg1 2875 DOC: More on pandas comparison max-sixty 5635139 closed 0     2 2019-04-07T21:24:44Z 2023-09-28T16:46:14Z 2023-09-28T16:46:14Z MEMBER   1 pydata/xarray/pulls/2875

Follow up from the mailing list: - Added some more thoughts on the multi-dimensional comparison. Some of this is opinionated (in concepts not arguments) so I'd appreciate feedback on both the concepts and language. - Removed some of the specific comparison with NDPanel etc, given those are removed - Placeholder for something on the Explicit API (wanted to get this version out, consistent with me leaving less work hanging)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2875/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1895568528 PR_kwDOAMm_X85aSh-V 8181 Set dev version above released version max-sixty 5635139 closed 0     2 2023-09-14T02:56:26Z 2023-09-14T20:54:36Z 2023-09-14T20:47:08Z MEMBER   0 pydata/xarray/pulls/8181

Pandas asserts that the xarray version that's running is above 2022.; locally it was set to 999 which failed this. It only applies when developing locally.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8181/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1221395426 PR_kwDOAMm_X843GAxX 6544 Attempt to improve CI caching, v2 max-sixty 5635139 closed 0     2 2022-04-29T18:40:31Z 2022-06-10T14:36:12Z 2022-06-10T11:33:00Z MEMBER   1 pydata/xarray/pulls/6544

Reverts pydata/xarray#6543 as discussed.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6544/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1218276081 PR_kwDOAMm_X8427ENH 6536 Remove duplicate tests max-sixty 5635139 closed 0     2 2022-04-28T06:43:18Z 2022-04-29T17:49:06Z 2022-04-29T17:47:04Z MEMBER   0 pydata/xarray/pulls/6536

Merge this in a few days when we know nothing is missing

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6536/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1218065176 PR_kwDOAMm_X8426XPm 6532 Restrict annotations to a single run in GHA max-sixty 5635139 closed 0     2 2022-04-28T01:30:51Z 2022-04-28T06:38:10Z 2022-04-28T03:17:22Z MEMBER   0 pydata/xarray/pulls/6532

Currently we get a lot of duplicates:

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6532/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1207198806 PR_kwDOAMm_X842XpSv 6498 Restrict stalebot on projects & milestones max-sixty 5635139 closed 0     2 2022-04-18T16:11:10Z 2022-04-18T16:25:08Z 2022-04-18T16:11:12Z MEMBER   0 pydata/xarray/pulls/6498

Closes #6497

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6498/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1200531581 PR_kwDOAMm_X842B792 6474 Fix `Number` import max-sixty 5635139 closed 0     2 2022-04-11T21:04:47Z 2022-04-11T22:18:31Z 2022-04-11T21:07:51Z MEMBER   0 pydata/xarray/pulls/6474   
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6474/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1098504712 PR_kwDOAMm_X84ww9To 6152 Add pyupgrade onto pre-commit max-sixty 5635139 closed 0     2 2022-01-10T23:52:30Z 2022-01-19T20:40:16Z 2022-01-19T20:39:39Z MEMBER   0 pydata/xarray/pulls/6152
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

This auto-fixes problems, so the bar to add it on is low...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6152/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1076340035 PR_kwDOAMm_X84vp0L8 6060 Add release notes for 0.20.2 max-sixty 5635139 closed 0     2 2021-12-10T02:03:24Z 2021-12-10T02:58:58Z 2021-12-10T02:04:29Z MEMBER   0 pydata/xarray/pulls/6060 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6060/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
976210502 MDExOlB1bGxSZXF1ZXN0NzE3MjAxNTUz 5728 Type annotate tests max-sixty 5635139 closed 0     2 2021-08-21T19:56:06Z 2021-08-22T04:00:14Z 2021-08-22T03:32:22Z MEMBER   0 pydata/xarray/pulls/5728
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Following on from https://github.com/pydata/xarray/pull/5690 & https://github.com/pydata/xarray/pull/5694, this type annotates most test files; though probably not most tests — I haven't done the huge files. They require between zero and a dozen fixes, and just ignoring assignment ignores some but not all the errors (I didn't end up using it much).

It also does useful things — fixes a bunch more annotations!

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5728/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
974282338 MDExOlB1bGxSZXF1ZXN0NzE1NjEwMDE3 5714 Whatsnew for float-to-top max-sixty 5635139 closed 0     2 2021-08-19T05:21:00Z 2021-08-19T17:26:14Z 2021-08-19T17:26:11Z MEMBER   0 pydata/xarray/pulls/5714 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5714/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
930516190 MDExOlB1bGxSZXF1ZXN0Njc4MTkyMTUz 5537 Fix junit test results max-sixty 5635139 closed 0     2 2021-06-25T21:32:02Z 2021-06-25T22:51:02Z 2021-06-25T22:21:41Z MEMBER   0 pydata/xarray/pulls/5537
  • [x] Passes pre-commit run --all-files

(may require some iteration)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5537/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
907746039 MDExOlB1bGxSZXF1ZXN0NjU4NTQzMjYx 5412 Add junit test results to CI max-sixty 5635139 closed 0     2 2021-05-31T22:52:11Z 2021-06-03T03:46:00Z 2021-06-03T03:18:28Z MEMBER   0 pydata/xarray/pulls/5412
  • [x] Passes pre-commit run --all-files

I'm not sure this is the best approach; potentially the comment this app adds is too noisy: https://github.com/marketplace/actions/publish-unit-test-results.

But it would be good to get an idea of the test results from the PR page and to understand where the test suite spends its time

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5412/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
907723038 MDExOlB1bGxSZXF1ZXN0NjU4NTI0NTM4 5410 Promote backend test fixture to conftest max-sixty 5635139 closed 0     2 2021-05-31T21:28:39Z 2021-06-02T16:17:02Z 2021-06-02T16:16:59Z MEMBER   0 pydata/xarray/pulls/5410

Also adds an example of parameterizing a test in dataset.py

  • [x] Passes pre-commit run --all-files

This uses the backend fixture (though not the dataset fixture, like https://github.com/pydata/xarray/pull/5350/files did)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5410/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
897112103 MDExOlB1bGxSZXF1ZXN0NjQ5MTQ4MDkx 5353 Use dict in docs Dataset construction max-sixty 5635139 closed 0     2 2021-05-20T16:48:07Z 2021-05-21T22:37:28Z 2021-05-21T22:37:25Z MEMBER   0 pydata/xarray/pulls/5353
  • [x] Passes pre-commit run --all-files

As discussed in other issues — I find this way significantly easier to read, particularly when we're passing tuples of tuples as part of the construction. I did these manually but can write something to do it more broadly if people agree.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5353/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
817091683 MDExOlB1bGxSZXF1ZXN0NTgwNjQyNzYw 4964 Some refinements to How To Release max-sixty 5635139 closed 0     2 2021-02-26T06:47:17Z 2021-02-26T21:53:28Z 2021-02-26T19:11:43Z MEMBER   0 pydata/xarray/pulls/4964 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4964/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
684078209 MDExOlB1bGxSZXF1ZXN0NDcyMDQ3Mzk0 4369 Silencing numpy warnings max-sixty 5635139 closed 0     2 2020-08-22T22:31:11Z 2021-02-21T23:05:00Z 2020-09-02T22:26:32Z MEMBER   0 pydata/xarray/pulls/4369
  • [x] Closes #3811
  • [x] Tests added
  • [x] Passes isort . && black . && mypy . && flake8
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Is this the right approach? Or should we be using np.errstate machinery?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4369/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
777580305 MDExOlB1bGxSZXF1ZXN0NTQ3ODM3MTU1 4752 Replace bare assert with assert_identical max-sixty 5635139 closed 0     2 2021-01-03T05:59:05Z 2021-01-05T04:18:33Z 2021-01-04T02:13:05Z MEMBER   0 pydata/xarray/pulls/4752
  • [x] closes #3908
  • [x] Passes isort . && black . && mypy . && flake8

IIRC assert_identical shows nice pytest error messages.

This was a quick regex but did a quick check that it looked reasonable.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4752/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
777588292 MDExOlB1bGxSZXF1ZXN0NTQ3ODQyOTEy 4754 Write black diff on errors max-sixty 5635139 closed 0     2 2021-01-03T07:17:45Z 2021-01-03T20:57:22Z 2021-01-03T20:57:19Z MEMBER   0 pydata/xarray/pulls/4754
  • [x] Passes isort . && black . && mypy . && flake8
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

Inspired by @Illviljan in https://github.com/pydata/xarray/pull/4750

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4754/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
298620060 MDExOlB1bGxSZXF1ZXN0MTcwMjEyMDc3 1927 Some backend tests require dask max-sixty 5635139 closed 0     2 2018-02-20T14:46:30Z 2020-11-08T21:08:43Z 2020-11-08T19:40:35Z MEMBER   0 pydata/xarray/pulls/1927

LMK if these are the right ones - I basically added the decorator to anything that was failing. Though not sure we need to be 100% accurate here - worst case we could skip the file - either people are writing backend code and have dask installed, or they're not...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1927/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
688638584 MDExOlB1bGxSZXF1ZXN0NDc1ODUyMjQ5 4388 Pin pre-commit versions max-sixty 5635139 closed 0     2 2020-08-30T02:19:55Z 2020-08-31T16:31:54Z 2020-08-31T16:31:49Z MEMBER   0 pydata/xarray/pulls/4388
  • [x] Passes isort . && black . && mypy . && flake8
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

I had some issues with the version changing — this approach seems more explicit and less likely to cause hard-to-debug issues

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4388/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
665834531 MDExOlB1bGxSZXF1ZXN0NDU2Nzg2OTQz 4273 Add requires_scipy to least_squares test max-sixty 5635139 closed 0     2 2020-07-26T18:23:34Z 2020-08-16T18:00:33Z 2020-08-16T18:00:29Z MEMBER   0 pydata/xarray/pulls/4273
  • [x] Passes isort . && black . && mypy . && flake8
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4273/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
655282530 MDExOlB1bGxSZXF1ZXN0NDQ3ODE5MjIx 4217 Add release summary, some touch-ups max-sixty 5635139 closed 0     2 2020-07-11T21:28:51Z 2020-07-26T19:17:02Z 2020-07-23T15:26:40Z MEMBER   0 pydata/xarray/pulls/4217

This PR: - Proposes adding a Release Summary with a PR. This is something that maybe more people read than anything else we send, and yet it's the least reviewed text of anything I write; and I'm making guesses on what's important. - Proposes pasting the release summary into the GH Release page; to the extent people follow xarray by following our releases, it's nice to have something there. - Some touch-ups

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4217/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
571802536 MDExOlB1bGxSZXF1ZXN0MzgwNjIyMzgy 3802 Raise on multiple string args to groupby max-sixty 5635139 closed 0     2 2020-02-27T03:50:03Z 2020-02-29T20:48:07Z 2020-02-29T20:47:12Z MEMBER   0 pydata/xarray/pulls/3802
  • [x] Tests added
  • [x] Passes isort -rc . && black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

From the comment:

While we don't generally check the type of every arg, passing multiple dimensions as multiple arguments is common enough, and the consequences hidden enough (strings evaluate as true) to warrant checking here. A future version could make squeeze kwarg only, but would face backward-compat issues.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3802/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
551727037 MDExOlB1bGxSZXF1ZXN0MzY0Mzk2MTk3 3707 remove PR pre-black instructions max-sixty 5635139 closed 0     2 2020-01-18T06:01:15Z 2020-01-29T21:39:10Z 2020-01-29T17:21:31Z MEMBER   0 pydata/xarray/pulls/3707

I don't think these should be needed any longer

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3707/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
512873086 MDExOlB1bGxSZXF1ZXN0MzMyNzkyOTM2 3451 Remove deprecated behavior from dataset.drop docstring max-sixty 5635139 closed 0     2 2019-10-26T19:06:16Z 2019-10-29T15:03:53Z 2019-10-29T14:49:17Z MEMBER   0 pydata/xarray/pulls/3451

I'm less up to speed on this behavior, but IIUC this part of the docstring refers to deprecated behavior—is that correct or am I missing something?

xref https://github.com/pydata/xarray/issues/3266 

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3451/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
509490043 MDExOlB1bGxSZXF1ZXN0MzMwMDQ0MDY2 3419 Python3.6 idioms max-sixty 5635139 closed 0     2 2019-10-19T18:15:48Z 2019-10-21T01:32:07Z 2019-10-21T00:16:58Z MEMBER   0 pydata/xarray/pulls/3419
  • [x] Passes black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

Use python 3.6+ idioms; most changes are f-strings

Mostly from pyupgrade --py36-plus **/*.py

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3419/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
490746942 MDExOlB1bGxSZXF1ZXN0MzE1MjY5NjIw 3292 Remove some deprecations max-sixty 5635139 closed 0     2 2019-09-08T12:14:31Z 2019-09-08T22:58:28Z 2019-09-08T22:58:16Z MEMBER   0 pydata/xarray/pulls/3292
  • [x] Closes some of #3280
  • [x] Passes black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3292/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
478715330 MDExOlB1bGxSZXF1ZXN0MzA1NzcyMTc4 3195 Update black instructions max-sixty 5635139 closed 0     2 2019-08-08T22:28:59Z 2019-08-09T00:27:28Z 2019-08-09T00:27:09Z MEMBER   0 pydata/xarray/pulls/3195

This needed updating with the relevant commit post-black change

I also added a line to apply the patch of manual changes we made on top of the black changes. It makes the list of steps a bit burdensome. But I've tested them a couple of times and, where people have lots of code changes, it's still going to be much easier than resolving manually.

I generally wouldn't want to suggest people curl data from the internet (even if we trust the individual). I think it's probably OK in this instance: the address contains a hash of the contents, and it's only being fed into git apply -, not executed. But lmk if that's still a security concern.

I'll update the issue I opened on black with the above issue; we should have done one commit with only the black changes, and then another with any manual changes.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3195/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
455275723 MDExOlB1bGxSZXF1ZXN0Mjg3NTU4MTE3 3019 Update issue templates max-sixty 5635139 closed 0     2 2019-06-12T15:19:04Z 2019-06-15T03:35:23Z 2019-06-15T03:35:17Z MEMBER   0 pydata/xarray/pulls/3019

This: - Updates to the newer GitHub format - Strengthens the language around MCVE. It doesn't say people have to, but makes it less of a suggestion - Only contains 'Bug Report'. Should we have others? I don't immediately see how they'd be different

(I realize because I did this from the GH website, it created from this repo rather than my own fork. That's a mistake.)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3019/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
454313971 MDExOlB1bGxSZXF1ZXN0Mjg2NzkwNDg5 3011 Pytest capture uses match, not message max-sixty 5635139 closed 0     2 2019-06-10T18:46:43Z 2019-06-11T15:01:23Z 2019-06-11T15:01:19Z MEMBER   0 pydata/xarray/pulls/3011
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

message was always going being ignored, and with the newer pytest version raises a warning that an unknown kwarg is supplied

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3011/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
393807679 MDExOlB1bGxSZXF1ZXN0MjQwNzE4NDAx 2629 Flake fixed max-sixty 5635139 closed 0     2 2018-12-24T04:23:47Z 2019-06-10T19:09:44Z 2018-12-25T01:21:50Z MEMBER   0 pydata/xarray/pulls/2629 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2629/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
402783087 MDExOlB1bGxSZXF1ZXN0MjQ3Mzg4NzMx 2703 deprecate compat & encoding max-sixty 5635139 closed 0     2 2019-01-24T16:14:21Z 2019-02-01T03:16:13Z 2019-02-01T03:16:10Z MEMBER   0 pydata/xarray/pulls/2703

Still need to adjust the tests

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2703/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
399340074 MDExOlB1bGxSZXF1ZXN0MjQ0NzkwMjQ5 2677 Small typo max-sixty 5635139 closed 0     2 2019-01-15T13:15:31Z 2019-01-15T15:40:19Z 2019-01-15T13:29:54Z MEMBER   0 pydata/xarray/pulls/2677

@fujiisoup is this a small typo?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2677/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
367493434 MDExOlB1bGxSZXF1ZXN0MjIwOTA5OTkx 2470 fill_value in shift max-sixty 5635139 closed 0     2 2018-10-06T20:33:29Z 2018-12-28T01:07:17Z 2018-12-27T22:58:30Z MEMBER   0 pydata/xarray/pulls/2470
  • [x] Closes #https://github.com/pydata/xarray/issues/2451
  • [x] Tests added
  • [x] Tests passed
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

Should we be more defensive around which fill_values can be passed? Currently, if the array and float values have incompatible dtypes, we don't preemtively warn or cast, apart from the case of np.nan, which then uses the default filler

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2470/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
367486218 MDExOlB1bGxSZXF1ZXN0MjIwOTA1MTkw 2469 isort max-sixty 5635139 closed 0     2 2018-10-06T19:05:54Z 2018-10-08T01:38:00Z 2018-10-07T22:39:14Z MEMBER   0 pydata/xarray/pulls/2469

Do we want to keep isort up to date? I think it's a balance between consistency vs. overhead

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2469/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
194243942 MDExOlB1bGxSZXF1ZXN0OTcwNTcwMzI= 1157 PERF: Use len rather than size max-sixty 5635139 closed 0     2 2016-12-08T04:23:24Z 2016-12-09T18:36:50Z 2016-12-09T18:36:50Z MEMBER   0 pydata/xarray/pulls/1157 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1157/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);