issues: 478715330

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
478715330 MDExOlB1bGxSZXF1ZXN0MzA1NzcyMTc4 3195 Update black instructions 5635139 closed 0     2 2019-08-08T22:28:59Z 2019-08-09T00:27:28Z 2019-08-09T00:27:09Z MEMBER   0 pydata/xarray/pulls/3195

This needed updating with the relevant commit post-black change

I also added a line to apply the patch of manual changes we made on top of the black changes. It makes the list of steps a bit burdensome. But I've tested them a couple of times and, where people have lots of code changes, it's still going to be much easier than resolving manually.

I generally wouldn't want to suggest people curl data from the internet (even if we trust the individual). I think it's probably OK in this instance: the address contains a hash of the contents, and it's only being fed into git apply -, not executed. But lmk if that's still a security concern.

I'll update the issue I opened on black with the above issue; we should have done one commit with only the black changes, and then another with any manual changes.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3195/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables