issues

Table actions

17 rows where comments = 1, type = "pull" and user = 43316012 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: draft, created_at (date), updated_at (date), closed_at (date)

state 2

type 1

  • pull · 17 ✖

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1914212923 PR_kwDOAMm_X85bRN9f 8234 Improved typing of align & broadcast headtr1ck 43316012 closed 0     1 2023-09-26T20:02:22Z 2023-12-18T20:28:03Z 2023-10-09T10:21:40Z COLLABORATOR   0 pydata/xarray/pulls/8234
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

This PR improves the typing of align. Before: the type of the inputs was reduced to the common superclass and the return type was the same. This often required casts or ignores when mixing classes (e.g. da, ds = xr.align(da, ds). Now: the return types are exactly the same as the input types if the number of passed arguments is <=5.

Only downside: it requires some ugly overloads with type ignores on align. Maybe someone knows how to type this better?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8234/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
2021517557 PR_kwDOAMm_X85g7s9a 8501 Update to mypy1.7 headtr1ck 43316012 closed 0     1 2023-12-01T20:08:46Z 2023-12-02T13:08:45Z 2023-12-01T22:02:21Z COLLABORATOR   0 pydata/xarray/pulls/8501
  • [x] Closes #8448
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

I guess we update manually for now?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8501/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1943539215 PR_kwDOAMm_X85c0AkW 8309 Move variable typed ops to NamedArray headtr1ck 43316012 open 0     1 2023-10-14T20:22:07Z 2023-10-26T21:55:01Z   COLLABORATOR   1 pydata/xarray/pulls/8309

This is highly WIP and probably everything is broken right now... Just creating this now, so other people don't work on the same :) Feel free to continue here with me.

@pydata/xarray 1. what do we do with commonly used functions, is it ok to copy them? 2. Moving the typed ops requires a lot of functions to be added to NamedArray, is there a consensus of what we want to move? Is it basically everything? 3. Slowly the utils module is becomming a graveyard of stuff we dont want to put elsewhere, maybe we should at least move the typing stuff over to a types module.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8309/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1897167470 PR_kwDOAMm_X85aX_Ms 8184 Fix several warnings in the tests headtr1ck 43316012 closed 0     1 2023-09-14T19:21:37Z 2023-09-26T19:01:13Z 2023-09-15T20:41:03Z COLLABORATOR   0 pydata/xarray/pulls/8184

Mainly deprecated "closed" argument in date_range and passing pd.MultiIndex directly to the constructor.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8184/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1462057503 PR_kwDOAMm_X85DlALl 7315 Fix polyval overloads headtr1ck 43316012 closed 0     1 2022-11-23T16:27:21Z 2022-12-08T20:10:16Z 2022-11-26T15:42:51Z COLLABORATOR   0 pydata/xarray/pulls/7315
  • [x] Closes #7312
  • [ ] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~New functions/methods are listed in api.rst~

Turns out the default value of arguments is important for overloads, haha.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7315/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1468671915 PR_kwDOAMm_X85D65Bg 7335 Enable mypy warn unused ignores headtr1ck 43316012 closed 0     1 2022-11-29T20:42:08Z 2022-12-08T20:09:06Z 2022-12-01T16:14:07Z COLLABORATOR   0 pydata/xarray/pulls/7335

This PR adds the mypy option "warn_unused_ignores" which will raise an error if a # type: ignore is used where it is no longer necessary.

Should enable us to keep our types updated.

I am not sure if this will lead to many issues whenever e.g. numpy changes/improves their typing, so we might get errors whenever there is a new version. Maybe it is not that bad, or maybe we can also remove the option again and only do it manually from time to time?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7335/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1410498749 PR_kwDOAMm_X85A38a6 7168 Fix broken test that fails CI upstream headtr1ck 43316012 closed 0     1 2022-10-16T14:02:42Z 2022-10-17T17:48:07Z 2022-10-16T16:16:51Z COLLABORATOR   0 pydata/xarray/pulls/7168
  • [x] Closes #7158

Technically does not close all fails, but if we close it, the CI will open a new issue anyway and the discussion is not relevant anymore :)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7168/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1396832809 PR_kwDOAMm_X85AKhqW 7126 Upload mypy coverage report to codecov headtr1ck 43316012 closed 0     1 2022-10-04T20:55:02Z 2022-10-06T21:33:51Z 2022-10-06T20:38:14Z COLLABORATOR   0 pydata/xarray/pulls/7126

Not sure if that is the correct approach (to simply use a mypy flag) but lets see what people think about it.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7126/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1389764085 PR_kwDOAMm_X84_zMRw 7102 Exclude typechecking stuff from coverage headtr1ck 43316012 closed 0     1 2022-09-28T18:12:39Z 2022-09-28T20:15:52Z 2022-09-28T19:18:54Z COLLABORATOR   0 pydata/xarray/pulls/7102

tiny PR that disables coverage on types.py and all typing-only imports a.la. if TYPE_CHECKING: ...

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7102/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1345227910 PR_kwDOAMm_X849gI4A 6939 Improve quantile method docstring + error headtr1ck 43316012 closed 0     1 2022-08-20T17:17:32Z 2022-09-10T09:03:05Z 2022-09-05T22:40:07Z COLLABORATOR   0 pydata/xarray/pulls/6939
  • [x] Closes #6875
  • [x] ~~Tests added~~
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~~New functions/methods are listed in api.rst~~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6939/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1345220697 PR_kwDOAMm_X849gHlT 6938 Fix bug where indexes were changed inplace headtr1ck 43316012 closed 0     1 2022-08-20T16:45:22Z 2022-08-22T11:07:46Z 2022-08-22T10:39:54Z COLLABORATOR   0 pydata/xarray/pulls/6938
  • [x] Closes #6931
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] ~~New functions/methods are listed in api.rst~~

Some typing on the way :)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6938/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1302461674 PR_kwDOAMm_X847SR33 6777 Move Rolling tests to their own testing module headtr1ck 43316012 closed 0     1 2022-07-12T18:20:58Z 2022-07-12T18:48:38Z 2022-07-12T18:46:32Z COLLABORATOR   0 pydata/xarray/pulls/6777

This PR moves all DataArrayRolling and DatasetRolling tests to their own module.

See request https://github.com/pydata/xarray/pull/6744#issuecomment-1182169308

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6777/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1249902974 PR_kwDOAMm_X844idGc 6641 Typing of `str` and `dt` accessors headtr1ck 43316012 closed 0     1 2022-05-26T18:25:44Z 2022-05-27T06:32:33Z 2022-05-26T20:12:23Z COLLABORATOR   0 pydata/xarray/pulls/6641

This is initial try to get type hints for str and dt accessors.

I think there is no way of accessing the class at class scope (or is there?), so I had to use plain "DataArray" as the generic type of the accessors. I think that is acceptable for now.

The hack of DatetimeAccessor vs TimedeltaAccessor in the CombinedDatetimelikeAccessor.__new__ is something static typing can handle, so at type-checking time all properties of both accessors are available. If someone has a better idea?

Maybe a common interface class for accessors would be also beneficial?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6641/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
     xarray 13221727 pull
1244082778 PR_kwDOAMm_X844PPS5 6626 Mypy badge headtr1ck 43316012 closed 0     1 2022-05-21T21:12:05Z 2022-05-22T13:56:45Z 2022-05-21T22:59:52Z COLLABORATOR   0 pydata/xarray/pulls/6626

This PR adds a mypy badge to the README.

Also, nicer alt texts for all other badges.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6626/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1234229210 PR_kwDOAMm_X843u7hK 6601 change polyval dim ordering headtr1ck 43316012 closed 0     1 2022-05-12T16:30:44Z 2022-05-16T18:10:03Z 2022-05-12T19:01:59Z COLLABORATOR   0 pydata/xarray/pulls/6601
  • [x] Closes #6600
  • [x] Tests added
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6601/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1234135124 PR_kwDOAMm_X843unh4 6599 re-add timedelta support for polyval headtr1ck 43316012 closed 0     1 2022-05-12T15:12:41Z 2022-05-12T16:27:01Z 2022-05-12T15:43:29Z COLLABORATOR   0 pydata/xarray/pulls/6599
  • [x] Closes #6597
  • [x] Tests added
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6599/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1228977960 PR_kwDOAMm_X843dwXx 6579 Fix Dataset/DataArray.isel with drop=True and scalar DataArray indexes headtr1ck 43316012 closed 0     1 2022-05-08T20:17:04Z 2022-05-11T17:19:53Z 2022-05-10T06:18:19Z COLLABORATOR   0 pydata/xarray/pulls/6579
  • [x] Closes #6554
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Additionally I have added new literal types for error handling (Only applied to functions related to isel such that mypy stops complaining).

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6579/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);