issues: 832940300

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
832940300 MDExOlB1bGxSZXF1ZXN0NTk0MDIwNjg4 5041 combine keep_attrs and combine_attrs in apply_ufunc 14808389 closed 0     8 2021-03-16T15:46:30Z 2021-05-13T17:33:04Z 2021-05-13T17:25:52Z MEMBER   0 pydata/xarray/pulls/5041

As discussed this extends keep_attrs in apply_ufunc to also accept merge strategy names and use merge_attrs (making it easier to add more merge strategies).

Handling attrs on variables / coords is still missing.

  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5041/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables