issue_comments

Table actions

8 rows where issue = 832940300 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • combine keep_attrs and combine_attrs in apply_ufunc · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
840710248 https://github.com/pydata/xarray/pull/5041#issuecomment-840710248 https://api.github.com/repos/pydata/xarray/issues/5041 MDEyOklzc3VlQ29tbWVudDg0MDcxMDI0OA== dcherian 2448579 2021-05-13T17:25:40Z 2021-05-13T17:25:40Z MEMBER

Thanks @keewis. I found the compute_attrs thing a little complicated and hard to understand. But I think it's OK and am going to merge now. If you have a clever idea for something clearer, we can address that later.

Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine keep_attrs and combine_attrs in apply_ufunc 832940300
835467926 https://github.com/pydata/xarray/pull/5041#issuecomment-835467926 https://api.github.com/repos/pydata/xarray/issues/5041 MDEyOklzc3VlQ29tbWVudDgzNTQ2NzkyNg== keewis 14808389 2021-05-08T18:45:58Z 2021-05-08T18:45:58Z MEMBER

(Whatsnew needs switching versions FYI)

thanks, I completely missed that

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine keep_attrs and combine_attrs in apply_ufunc 832940300
835453535 https://github.com/pydata/xarray/pull/5041#issuecomment-835453535 https://api.github.com/repos/pydata/xarray/issues/5041 MDEyOklzc3VlQ29tbWVudDgzNTQ1MzUzNQ== keewis 14808389 2021-05-08T18:08:05Z 2021-05-08T18:08:05Z MEMBER

not sure if I got all of the issues I thought I noticed, but I think this should be ready

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine keep_attrs and combine_attrs in apply_ufunc 832940300
833098582 https://github.com/pydata/xarray/pull/5041#issuecomment-833098582 https://api.github.com/repos/pydata/xarray/issues/5041 MDEyOklzc3VlQ29tbWVudDgzMzA5ODU4Mg== max-sixty 5635139 2021-05-05T22:49:00Z 2021-05-05T22:49:00Z MEMBER

this is ready, too. Not sure if we should merge before the release, though.

As good a time as any! But as ever your call on whether we can be sufficiently confident

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine keep_attrs and combine_attrs in apply_ufunc 832940300
833037440 https://github.com/pydata/xarray/pull/5041#issuecomment-833037440 https://api.github.com/repos/pydata/xarray/issues/5041 MDEyOklzc3VlQ29tbWVudDgzMzAzNzQ0MA== keewis 14808389 2021-05-05T21:46:58Z 2021-05-05T21:46:58Z MEMBER

this is ready, too. Not sure if we should merge before the release, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine keep_attrs and combine_attrs in apply_ufunc 832940300
822805226 https://github.com/pydata/xarray/pull/5041#issuecomment-822805226 https://api.github.com/repos/pydata/xarray/issues/5041 MDEyOklzc3VlQ29tbWVudDgyMjgwNTIyNg== keewis 14808389 2021-04-19T21:42:16Z 2021-04-19T21:42:16Z MEMBER

apply_ufunc ultimately calls merge_collected to determine the output coords so we would need #4902 to also keep the attrs on coords.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine keep_attrs and combine_attrs in apply_ufunc 832940300
822788648 https://github.com/pydata/xarray/pull/5041#issuecomment-822788648 https://api.github.com/repos/pydata/xarray/issues/5041 MDEyOklzc3VlQ29tbWVudDgyMjc4ODY0OA== dcherian 2448579 2021-04-19T21:13:25Z 2021-04-19T21:13:25Z MEMBER

if we should try to combine attrs on coord

:+1: on this. can fix later though...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine keep_attrs and combine_attrs in apply_ufunc 832940300
806264941 https://github.com/pydata/xarray/pull/5041#issuecomment-806264941 https://api.github.com/repos/pydata/xarray/issues/5041 MDEyOklzc3VlQ29tbWVudDgwNjI2NDk0MQ== keewis 14808389 2021-03-25T00:13:59Z 2021-03-25T00:13:59Z MEMBER

it seems apply_ufunc already applies keep_attrs/combine_attrs on the data variables, but not the coords. Not sure if we should try to combine attrs on coords, too (should be fixed by adding a keep_attrs kwarg to align / deep_align)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   combine keep_attrs and combine_attrs in apply_ufunc 832940300

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);