issue_comments

Table actions

7 rows where issue = 777586739 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Replace SortedKeysDict with dict · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
841894087 https://github.com/pydata/xarray/pull/4753#issuecomment-841894087 https://api.github.com/repos/pydata/xarray/issues/4753 MDEyOklzc3VlQ29tbWVudDg0MTg5NDA4Nw== max-sixty 5635139 2021-05-16T23:27:43Z 2021-05-16T23:27:43Z MEMBER

I worry about the dimension sizes which are part of the first line of the Dataset repr, though: we've had lots of questions about this because people thought that it would mean the same as in a DataArray's repr (the order there has a meaning). Arguably, that's because the difference between them is not big enough. This seems to have become less frequent since the introduction of the HTML reprs, so maybe it is also less important?

I agree the current situation isn't ideal (though I'm not sure there's a better one) but also that this doesn't make it much worse — the existing approach doesn't represent an useful ordering, and nor does this. And if we choose to make it mean something in the future, then this is a necessary step towards that...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace SortedKeysDict with dict 777586739
766181132 https://github.com/pydata/xarray/pull/4753#issuecomment-766181132 https://api.github.com/repos/pydata/xarray/issues/4753 MDEyOklzc3VlQ29tbWVudDc2NjE4MTEzMg== pep8speaks 24736507 2021-01-23T21:21:00Z 2021-05-16T03:24:39Z NONE

Hello @max-sixty! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-05-16 03:24:39 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace SortedKeysDict with dict 777586739
840652964 https://github.com/pydata/xarray/pull/4753#issuecomment-840652964 https://api.github.com/repos/pydata/xarray/issues/4753 MDEyOklzc3VlQ29tbWVudDg0MDY1Mjk2NA== max-sixty 5635139 2021-05-13T15:50:55Z 2021-05-13T15:50:55Z MEMBER

I think combine_by_coords is brittle in case of ambiguous concat dims as in the given example

@mathause if this is a new bug then can you make an issue for it please?

Isn't this #4824?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace SortedKeysDict with dict 777586739
840634675 https://github.com/pydata/xarray/pull/4753#issuecomment-840634675 https://api.github.com/repos/pydata/xarray/issues/4753 MDEyOklzc3VlQ29tbWVudDg0MDYzNDY3NQ== TomNicholas 35968931 2021-05-13T15:21:44Z 2021-05-13T15:21:44Z MEMBER

I think combine_by_coords is brittle in case of ambiguous concat dims as in the given example

@mathause if this is a new bug then can you make an issue for it please?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace SortedKeysDict with dict 777586739
840200753 https://github.com/pydata/xarray/pull/4753#issuecomment-840200753 https://api.github.com/repos/pydata/xarray/issues/4753 MDEyOklzc3VlQ29tbWVudDg0MDIwMDc1Mw== max-sixty 5635139 2021-05-13T00:48:25Z 2021-05-13T00:48:25Z MEMBER

Ready to go!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace SortedKeysDict with dict 777586739
840100222 https://github.com/pydata/xarray/pull/4753#issuecomment-840100222 https://api.github.com/repos/pydata/xarray/issues/4753 MDEyOklzc3VlQ29tbWVudDg0MDEwMDIyMg== max-sixty 5635139 2021-05-12T21:12:22Z 2021-05-12T21:12:22Z MEMBER

This ended up being more work than expected, but I think is ready for review. There's one issue that may be an existing bug (but may be my misunderstanding).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace SortedKeysDict with dict 777586739
755427061 https://github.com/pydata/xarray/pull/4753#issuecomment-755427061 https://api.github.com/repos/pydata/xarray/issues/4753 MDEyOklzc3VlQ29tbWVudDc1NTQyNzA2MQ== max-sixty 5635139 2021-01-06T16:59:17Z 2021-01-06T16:59:17Z MEMBER

As discussed in dev meeting, this makes sense to pursue. We should try and remove the repr sorting if we can manage the test breaks.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace SortedKeysDict with dict 777586739

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);