issues: 735267574

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
735267574 MDExOlB1bGxSZXF1ZXN0NTE0NjkwNTA3 4561 rm inplace arg to rename 17162724 closed 0     7 2020-11-03T12:10:12Z 2020-11-07T06:55:49Z 2020-11-07T06:55:49Z CONTRIBUTOR   0 pydata/xarray/pulls/4561

This PR follows a TypeError I got

ds = xr.open_dataset('https://thredds.ucar.edu/thredds/dodsC/grib/NCEP/GFS/Global_0p25deg/Best') ds.rename({'lat': 'latitude', 'lon': 'longitude'}, inplace=True) TypeError: The `inplace` argument has been removed from xarray. You can achieve an identical effect with python's standard assignment.

I saw the option of the inplace in the docs http://xarray.pydata.org/en/stable/generated/xarray.Dataset.rename.html

Removing this argument.

TODO:

  • [ ] rm test_rename_inplace
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4561/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables