issue_comments

Table actions

7 rows where issue = 735267574 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • rm inplace arg to rename · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
722018835 https://github.com/pydata/xarray/pull/4561#issuecomment-722018835 https://api.github.com/repos/pydata/xarray/issues/4561 MDEyOklzc3VlQ29tbWVudDcyMjAxODgzNQ== max-sixty 5635139 2020-11-04T22:55:38Z 2020-11-04T22:55:38Z MEMBER

Erm, actually I think you may have to take it off WIP first

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rm inplace arg to rename 735267574
722018674 https://github.com/pydata/xarray/pull/4561#issuecomment-722018674 https://api.github.com/repos/pydata/xarray/issues/4561 MDEyOklzc3VlQ29tbWVudDcyMjAxODY3NA== max-sixty 5635139 2020-11-04T22:55:07Z 2020-11-04T22:55:07Z MEMBER

Great, merging! Thanks @raybellwaves !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rm inplace arg to rename 735267574
721078708 https://github.com/pydata/xarray/pull/4561#issuecomment-721078708 https://api.github.com/repos/pydata/xarray/issues/4561 MDEyOklzc3VlQ29tbWVudDcyMTA3ODcwOA== pep8speaks 24736507 2020-11-03T12:10:20Z 2020-11-04T21:27:35Z NONE

Hello @raybellwaves! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-11-04 21:27:35 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rm inplace arg to rename 735267574
721973815 https://github.com/pydata/xarray/pull/4561#issuecomment-721973815 https://api.github.com/repos/pydata/xarray/issues/4561 MDEyOklzc3VlQ29tbWVudDcyMTk3MzgxNQ== max-sixty 5635139 2020-11-04T21:03:30Z 2020-11-04T21:03:30Z MEMBER

I don't think we have a strict policy but a few releases seem fine. Eventually they should go all go; but fine to merge them as we go too.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rm inplace arg to rename 735267574
721845992 https://github.com/pydata/xarray/pull/4561#issuecomment-721845992 https://api.github.com/repos/pydata/xarray/issues/4561 MDEyOklzc3VlQ29tbWVudDcyMTg0NTk5Mg== mathause 10194086 2020-11-04T16:47:26Z 2020-11-04T16:47:26Z MEMBER

This was in 0.13 http://xarray.pydata.org/en/stable/whats-new.html#v0-13-0-17-sep-2019 I actually don't know if we have an official policy for deprecations? Two major versions?

Should all of these checks be removed? #3260

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rm inplace arg to rename 735267574
721277539 https://github.com/pydata/xarray/pull/4561#issuecomment-721277539 https://api.github.com/repos/pydata/xarray/issues/4561 MDEyOklzc3VlQ29tbWVudDcyMTI3NzUzOQ== max-sixty 5635139 2020-11-03T17:39:45Z 2020-11-03T17:39:45Z MEMBER

One alternative is to remove inplace from the signature, and instead extract it from kwargs. As above, I would be fine removing it, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rm inplace arg to rename 735267574
721204756 https://github.com/pydata/xarray/pull/4561#issuecomment-721204756 https://api.github.com/repos/pydata/xarray/issues/4561 MDEyOklzc3VlQ29tbWVudDcyMTIwNDc1Ng== max-sixty 5635139 2020-11-03T15:37:25Z 2020-11-03T15:37:25Z MEMBER

The reason this was here is so people get a useful error as they make the transition.

It's probably been there long enough that we can remove it (no strong view though)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rm inplace arg to rename 735267574

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);