issues: 714844298
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
714844298 | MDExOlB1bGxSZXF1ZXN0NDk3ODU3MTA0 | 4485 | Handle scale_factor and add_offset as scalar | 500246 | closed | 0 | 3 | 2020-10-05T13:31:36Z | 2020-10-16T21:20:14Z | 2020-10-11T20:06:33Z | CONTRIBUTOR | 0 | pydata/xarray/pulls/4485 | The h5netcdf engine exposes single-valued attributes as arrays of shape (1,), which is correct according to the NetCDF standard, but may cause a problem when reading a value of shape () before the scale_factor and add_offset have been applied. This PR adds a check for the dimensionality of add_offset and scale_factor and ensures they are scalar before they are used for further processing, adds a unit test to verify that this works correctly, and a note to the documentation to warn users of this difference between the h5netcdf and netcdf4 engines.
|
{ "url": "https://api.github.com/repos/pydata/xarray/issues/4485/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
13221727 | pull |