issue_comments

Table actions

3 rows where issue = 714844298 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Handle scale_factor and add_offset as scalar · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
706760658 https://github.com/pydata/xarray/pull/4485#issuecomment-706760658 https://api.github.com/repos/pydata/xarray/issues/4485 MDEyOklzc3VlQ29tbWVudDcwNjc2MDY1OA== dcherian 2448579 2020-10-11T20:06:26Z 2020-10-11T20:06:26Z MEMBER

Thanks @gerritholl 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle scale_factor and add_offset as scalar 714844298
704161345 https://github.com/pydata/xarray/pull/4485#issuecomment-704161345 https://api.github.com/repos/pydata/xarray/issues/4485 MDEyOklzc3VlQ29tbWVudDcwNDE2MTM0NQ== gerritholl 500246 2020-10-06T09:54:19Z 2020-10-06T09:54:19Z CONTRIBUTOR

If this makes more sense as an integration test than as a unit test (for which I need help, see other comment), should I mark the current test in some way and/or move it to a different source file?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle scale_factor and add_offset as scalar 714844298
703635258 https://github.com/pydata/xarray/pull/4485#issuecomment-703635258 https://api.github.com/repos/pydata/xarray/issues/4485 MDEyOklzc3VlQ29tbWVudDcwMzYzNTI1OA== gerritholl 500246 2020-10-05T13:33:38Z 2020-10-05T13:33:38Z CONTRIBUTOR

Is this bugfix notable enough to need a whats-new.rst entry?

For the unit test, I tried to construct an object that would emulate what is produced when reading a NetCDF4 file with the h5netcdf engine, but I gave up and settled for a temporary file instead. If this is an undesired approach, I could use some guidance in how to construct the appropriate object that will expose the problem.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle scale_factor and add_offset as scalar 714844298

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);