issues: 520507183

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
520507183 MDExOlB1bGxSZXF1ZXN0MzM5MDg0MjUz 3504 Allow appending datetime & boolean variables to zarr stores 463809 closed 0     5 2019-11-09T20:09:29Z 2019-11-13T18:47:42Z 2019-11-13T15:55:33Z CONTRIBUTOR   0 pydata/xarray/pulls/3504
  • [x] Closes #3480
  • [x] Tests added
  • [x] Passes black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

AFAICT, the type checking in the _validate_datatypes_for_zarr_append is simply too strict, and relaxing it seems to work fine. But this is my first time digging into the xarray source code, so please let me know if this issue is more complex.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3504/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables