issue_comments

Table actions

5 rows where issue = 520507183 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Allow appending datetime & boolean variables to zarr stores · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
553545547 https://github.com/pydata/xarray/pull/3504#issuecomment-553545547 https://api.github.com/repos/pydata/xarray/issues/3504 MDEyOklzc3VlQ29tbWVudDU1MzU0NTU0Nw== max-sixty 5635139 2019-11-13T18:47:42Z 2019-11-13T18:47:42Z MEMBER

Welcome @amatsukawa ! Great to have you as a contributor!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow appending datetime & boolean variables to zarr stores 520507183
553465633 https://github.com/pydata/xarray/pull/3504#issuecomment-553465633 https://api.github.com/repos/pydata/xarray/issues/3504 MDEyOklzc3VlQ29tbWVudDU1MzQ2NTYzMw== dcherian 2448579 2019-11-13T15:55:28Z 2019-11-13T15:55:28Z MEMBER

Thanks @amatsukawa !

I see this is your first PR. Welcome to xarray development!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow appending datetime & boolean variables to zarr stores 520507183
552480460 https://github.com/pydata/xarray/pull/3504#issuecomment-552480460 https://api.github.com/repos/pydata/xarray/issues/3504 MDEyOklzc3VlQ29tbWVudDU1MjQ4MDQ2MA== dcherian 2448579 2019-11-11T15:03:13Z 2019-11-11T15:03:13Z MEMBER

The tests look sufficient to me... but then again I haven't looked at the zarr code either.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow appending datetime & boolean variables to zarr stores 520507183
552166905 https://github.com/pydata/xarray/pull/3504#issuecomment-552166905 https://api.github.com/repos/pydata/xarray/issues/3504 MDEyOklzc3VlQ29tbWVudDU1MjE2NjkwNQ== max-sixty 5635139 2019-11-10T06:12:38Z 2019-11-10T06:12:38Z MEMBER

Perfect @amatsukawa !

Any comments from someone who knows the code? Otherwise tests look good enough to merge...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow appending datetime & boolean variables to zarr stores 520507183
552160158 https://github.com/pydata/xarray/pull/3504#issuecomment-552160158 https://api.github.com/repos/pydata/xarray/issues/3504 MDEyOklzc3VlQ29tbWVudDU1MjE2MDE1OA== amatsukawa 463809 2019-11-10T03:58:53Z 2019-11-10T03:58:53Z CONTRIBUTOR

Thanks @max-sixty, I made a small update to the error message. I had added a line to doc/whats-new.rst in 2e91693 is that what you were referring to?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow appending datetime & boolean variables to zarr stores 520507183

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);