issues: 512071129

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
512071129 MDExOlB1bGxSZXF1ZXN0MzMyMTUyMDg4 3443 jupyterlab dark theme 4806877 closed 0     11 2019-10-24T17:08:27Z 2019-10-29T03:47:28Z 2019-10-29T03:47:28Z CONTRIBUTOR   0 pydata/xarray/pulls/3443
  • [ ] Closes #xxxx
  • [ ] Tests added
  • [x] Passes black . && mypy . && flake8
  • [ ] Fully documented, including whats-new.rst for all changes and api.rst for new API

Follow on to #3425 to include support for jupyterlab dark theme. Note that this includes slight color changes. The most striking of which is that in jupyterlab light and regular notebook the even rows are white like the background.

Jlab dark

Jlab light

notebook

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3443/reactions",
    "total_count": 4,
    "+1": 4,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables