issue_comments

Table actions

11 rows where issue = 512071129 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • jupyterlab dark theme · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
547204584 https://github.com/pydata/xarray/pull/3443#issuecomment-547204584 https://api.github.com/repos/pydata/xarray/issues/3443 MDEyOklzc3VlQ29tbWVudDU0NzIwNDU4NA== shoyer 1217238 2019-10-29T00:31:32Z 2019-10-29T00:31:32Z MEMBER

Can we add a whatsnew with attribution?

I think this is covered by the previous PR adding the HTML repr?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   jupyterlab dark theme 512071129
547194915 https://github.com/pydata/xarray/pull/3443#issuecomment-547194915 https://api.github.com/repos/pydata/xarray/issues/3443 MDEyOklzc3VlQ29tbWVudDU0NzE5NDkxNQ== max-sixty 5635139 2019-10-28T23:49:34Z 2019-10-28T23:49:34Z MEMBER

Can we add a whatsnew with attribution?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   jupyterlab dark theme 512071129
547153085 https://github.com/pydata/xarray/pull/3443#issuecomment-547153085 https://api.github.com/repos/pydata/xarray/issues/3443 MDEyOklzc3VlQ29tbWVudDU0NzE1MzA4NQ== jsignell 4806877 2019-10-28T21:25:57Z 2019-10-28T21:25:57Z CONTRIBUTOR

Is this ready to merge?

Yeah I think so.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   jupyterlab dark theme 512071129
547152981 https://github.com/pydata/xarray/pull/3443#issuecomment-547152981 https://api.github.com/repos/pydata/xarray/issues/3443 MDEyOklzc3VlQ29tbWVudDU0NzE1Mjk4MQ== jsignell 4806877 2019-10-28T21:25:41Z 2019-10-28T21:25:41Z CONTRIBUTOR

Right I don't think jlab works in IE. But this won't work in regular notebook in IE either. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   jupyterlab dark theme 512071129
547149569 https://github.com/pydata/xarray/pull/3443#issuecomment-547149569 https://api.github.com/repos/pydata/xarray/issues/3443 MDEyOklzc3VlQ29tbWVudDU0NzE0OTU2OQ== dcherian 2448579 2019-10-28T21:16:22Z 2019-10-28T21:16:22Z MEMBER

Is this ready to merge?

Also if jupyter is using css variables, i assume that it too won't work well in IE?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   jupyterlab dark theme 512071129
546479671 https://github.com/pydata/xarray/pull/3443#issuecomment-546479671 https://api.github.com/repos/pydata/xarray/issues/3443 MDEyOklzc3VlQ29tbWVudDU0NjQ3OTY3MQ== benbovy 4160723 2019-10-25T19:18:59Z 2019-10-25T19:18:59Z MEMBER

For tables with many columns it might be useful. That’s not the case here, although I’ve found that it helps to track the list of variables when variable data and/or attributes reprs are unfolded. But yeah, it’s a detail. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   jupyterlab dark theme 512071129
546475647 https://github.com/pydata/xarray/pull/3443#issuecomment-546475647 https://api.github.com/repos/pydata/xarray/issues/3443 MDEyOklzc3VlQ29tbWVudDU0NjQ3NTY0Nw== jsignell 4806877 2019-10-25T19:06:51Z 2019-10-25T19:06:51Z CONTRIBUTOR

I don't really like the hover-background anyways if those rows aren't clickable and other things are. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   jupyterlab dark theme 512071129
546406563 https://github.com/pydata/xarray/pull/3443#issuecomment-546406563 https://api.github.com/repos/pydata/xarray/issues/3443 MDEyOklzc3VlQ29tbWVudDU0NjQwNjU2Mw== benbovy 4160723 2019-10-25T15:45:09Z 2019-10-25T15:45:09Z MEMBER

This looks great, I like it!

Slightly related: I've tried to add hover background color on variable items, using --jp-rendermime-table-row-hover-background, to be consistent with other rich outputs in jupyterlab, but unfortunately I couldn't make it work nicely.

If I remember well, this would need wrapping each variable item (name, dims, values, etc.) in a container, but then this wouldn't work well with display: contents. I might be wrong, though. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   jupyterlab dark theme 512071129
546118432 https://github.com/pydata/xarray/pull/3443#issuecomment-546118432 https://api.github.com/repos/pydata/xarray/issues/3443 MDEyOklzc3VlQ29tbWVudDU0NjExODQzMg== shoyer 1217238 2019-10-24T21:52:49Z 2019-10-24T21:52:49Z MEMBER

IE is pretty niche these days -- not even Microsoft is maintaining it. I expect that this is fine for most of our users, as long as the degradation is not too terrible.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   jupyterlab dark theme 512071129
546023436 https://github.com/pydata/xarray/pull/3443#issuecomment-546023436 https://api.github.com/repos/pydata/xarray/issues/3443 MDEyOklzc3VlQ29tbWVudDU0NjAyMzQzNg== jsignell 4806877 2019-10-24T17:35:03Z 2019-10-24T17:35:03Z CONTRIBUTOR

@benbovy in case you have ideas about which colors to use.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   jupyterlab dark theme 512071129
546018788 https://github.com/pydata/xarray/pull/3443#issuecomment-546018788 https://api.github.com/repos/pydata/xarray/issues/3443 MDEyOklzc3VlQ29tbWVudDU0NjAxODc4OA== jsignell 4806877 2019-10-24T17:22:46Z 2019-10-24T17:22:46Z CONTRIBUTOR

Note that this won't work in IE https://caniuse.com/#feat=css-variables

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   jupyterlab dark theme 512071129

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);