issues: 462401539

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
462401539 MDExOlB1bGxSZXF1ZXN0MjkzMTAxODQx 3065 kwargs.pop() cleanup 6213168 closed 0     7 2019-06-30T12:47:07Z 2019-07-09T20:06:13Z 2019-07-01T01:58:50Z MEMBER   0 pydata/xarray/pulls/3065

  • Clean up everywhere the pattern def my_func(*args, **kwargs): my_optional_arg = kwargs.pop('my_optional_arg', None) which was inherited from not being able to put named keyword arguments after *args in Python 2.

  • Fix bug in SplineInterpolator where the __init__ method would write to the class attributes of BaseInterpolator.

  • map_dataarray was unintentionally and subtly relying on _process_cmap_cbar_kwargs to modify the kwargs in place. _process_cmap_cbar_kwargs is now strictly read-only and the modifications in kwargs have been made explicit in the caller function.
  • Rename all 'kwds' to 'kwargs' for sake of coherency
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3065/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables