issue_comments

Table actions

7 rows where issue = 462401539 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • kwargs.pop() cleanup · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
507135502 https://github.com/pydata/xarray/pull/3065#issuecomment-507135502 https://api.github.com/repos/pydata/xarray/issues/3065 MDEyOklzc3VlQ29tbWVudDUwNzEzNTUwMg== crusaderky 6213168 2019-07-01T06:38:54Z 2019-07-01T06:38:54Z MEMBER

@shoyer maybe instead of percentage you can configure it to count the absolute number of lines not covered? 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   kwargs.pop() cleanup 462401539
507101931 https://github.com/pydata/xarray/pull/3065#issuecomment-507101931 https://api.github.com/repos/pydata/xarray/issues/3065 MDEyOklzc3VlQ29tbWVudDUwNzEwMTkzMQ== max-sixty 5635139 2019-07-01T03:20:58Z 2019-07-01T03:20:58Z MEMBER

Much cleaner! Thanks @crusaderky!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   kwargs.pop() cleanup 462401539
507090258 https://github.com/pydata/xarray/pull/3065#issuecomment-507090258 https://api.github.com/repos/pydata/xarray/issues/3065 MDEyOklzc3VlQ29tbWVudDUwNzA5MDI1OA== shoyer 1217238 2019-07-01T02:00:23Z 2019-07-01T02:00:23Z MEMBER

Thanks @crusaderky. I’m going to disable the codecov status check shortly. It’s nice to see the numbers, but it definitely is not helpful to block PRs merely because they are deleting lines of code that had test coverage!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   kwargs.pop() cleanup 462401539
507079120 https://github.com/pydata/xarray/pull/3065#issuecomment-507079120 https://api.github.com/repos/pydata/xarray/issues/3065 MDEyOklzc3VlQ29tbWVudDUwNzA3OTEyMA== crusaderky 6213168 2019-07-01T00:14:11Z 2019-07-01T00:14:11Z MEMBER

@shoyer all done. The worsened coverage is caused by removing a wealth of lines, so the lines that were already being missed weight more >__>

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   kwargs.pop() cleanup 462401539
507033543 https://github.com/pydata/xarray/pull/3065#issuecomment-507033543 https://api.github.com/repos/pydata/xarray/issues/3065 MDEyOklzc3VlQ29tbWVudDUwNzAzMzU0Mw== pep8speaks 24736507 2019-06-30T12:47:21Z 2019-06-30T23:38:14Z NONE

Hello @crusaderky! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-06-30 23:38:14 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   kwargs.pop() cleanup 462401539
507063270 https://github.com/pydata/xarray/pull/3065#issuecomment-507063270 https://api.github.com/repos/pydata/xarray/issues/3065 MDEyOklzc3VlQ29tbWVudDUwNzA2MzI3MA== codecov[bot] 22429695 2019-06-30T20:02:49Z 2019-06-30T23:38:03Z NONE

Codecov Report

Merging #3065 into master will decrease coverage by 0.02%. The diff coverage is 93.65%.

```diff @@ Coverage Diff @@

master #3065 +/-

========================================== - Coverage 93.81% 93.78% -0.03%
========================================== Files 68 68
Lines 13201 13156 -45
========================================== - Hits 12384 12338 -46
- Misses 817 818 +1 ```

| Impacted Files | Coverage Δ | | |---|---|---| | xarray/core/dask_array_compat.py | 100% <ø> (ø) | :arrow_up: | | xarray/core/resample.py | 92.95% <100%> (-0.1%) | :arrow_down: | | xarray/core/groupby.py | 97.86% <100%> (-0.01%) | :arrow_down: | | xarray/core/alignment.py | 97.52% <100%> (+0.45%) | :arrow_up: | | xarray/plot/utils.py | 96.41% <100%> (-0.03%) | :arrow_down: | | xarray/core/npcompat.py | 89.06% <100%> (+0.6%) | :arrow_up: | | xarray/core/nputils.py | 99.12% <100%> (ø) | :arrow_up: | | xarray/core/missing.py | 94.46% <100%> (+0.3%) | :arrow_up: | | xarray/plot/facetgrid.py | 96.75% <100%> (-0.08%) | :arrow_down: | | xarray/core/nanops.py | 93.27% <100%> (-2.66%) | :arrow_down: | | ... and 5 more | |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b3489b...74ed80e. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   kwargs.pop() cleanup 462401539
507036451 https://github.com/pydata/xarray/pull/3065#issuecomment-507036451 https://api.github.com/repos/pydata/xarray/issues/3065 MDEyOklzc3VlQ29tbWVudDUwNzAzNjQ1MQ== crusaderky 6213168 2019-06-30T13:27:57Z 2019-06-30T13:27:57Z MEMBER

@shoyer ready for review and merge

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   kwargs.pop() cleanup 462401539

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);