issues: 393622674

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
393622674 MDExOlB1bGxSZXF1ZXN0MjQwNjAyNDY0 2626 Source encoding always set when opening datasets 35968931 closed 0     4 2018-12-22T00:02:26Z 2018-12-31T16:53:18Z 2018-12-30T01:00:37Z MEMBER   0 pydata/xarray/pulls/2626

Closes #2550 by ensuring that the filename is always stored in the encoding dictionary of a dataset, under 'source'. Previously this feature would be backend-dependent.

This was motivated by wanting the preprocess function passed to open_mfdataset to have access to the filename of the dataset it is operating on. A specific use case is when you are opening a spatial grid of datasets, and want to apply a different operation to datasets at the edge of the grid (e.g. to deal with guard cells). It is therefore also relevant for discussion in #2159.

  • [x] Closes #2550
  • [x] Tests added
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2626/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables