issue_comments

Table actions

4 rows where issue = 393622674 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Source encoding always set when opening datasets · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
450531867 https://github.com/pydata/xarray/pull/2626#issuecomment-450531867 https://api.github.com/repos/pydata/xarray/issues/2626 MDEyOklzc3VlQ29tbWVudDQ1MDUzMTg2Nw== shoyer 1217238 2018-12-30T01:00:42Z 2018-12-30T01:00:42Z MEMBER

thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Source encoding always set when opening datasets 393622674
450530550 https://github.com/pydata/xarray/pull/2626#issuecomment-450530550 https://api.github.com/repos/pydata/xarray/issues/2626 MDEyOklzc3VlQ29tbWVudDQ1MDUzMDU1MA== shoyer 1217238 2018-12-30T00:24:22Z 2018-12-30T00:24:22Z MEMBER

I pushed a commit with a few doc additions, will merge shortly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Source encoding always set when opening datasets 393622674
450443134 https://github.com/pydata/xarray/pull/2626#issuecomment-450443134 https://api.github.com/repos/pydata/xarray/issues/2626 MDEyOklzc3VlQ29tbWVudDQ1MDQ0MzEzNA== dcherian 2448579 2018-12-28T23:32:07Z 2018-12-28T23:32:07Z MEMBER

I think the what's new entry could be a little clearer and it would be good to add this to the docs somewhere. Here's one option: http://xarray.pydata.org/en/stable/io.html?highlight=encoding#reading-encoded-data

LGTM otherwise

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Source encoding always set when opening datasets 393622674
449526975 https://github.com/pydata/xarray/pull/2626#issuecomment-449526975 https://api.github.com/repos/pydata/xarray/issues/2626 MDEyOklzc3VlQ29tbWVudDQ0OTUyNjk3NQ== pep8speaks 24736507 2018-12-22T00:02:31Z 2018-12-23T20:05:24Z NONE

Hello @TomNicholas! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. :beers:

Comment last updated on December 23, 2018 at 20:05 Hours UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Source encoding always set when opening datasets 393622674

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);