issues: 32919692

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
32919692 MDExOlB1bGxSZXF1ZXN0MTU1NTY5NTY= 113 Most of Python 3 support 327925 closed 0   664063 6 2014-05-06T18:31:56Z 2014-07-15T20:36:05Z 2014-05-09T01:39:01Z MEMBER   0 pydata/xarray/pulls/113

This isn't entirely finished, but I need to stop working on it for a bit, and I think enough of it is ready to be reviewed. The core code is passing its tests; the remaining failures are all in talking to the Scipy and netCDF4 backends. I also have PRs open against Scipy (scipy/scipy#3617) and netCDF4 (Unidata/netcdf4-python#252) to fix bugs I've encountered there.

Particular issues that came up: - There were quite a few circular imports. For now, I've fudged these to work rather than trying to reorganise the code. - isinstance(x, int) doesn't reliably catch numpy integer types - see e.g. numpy/numpy#2951. I changed several such cases to isinstance(x, (int, np.integer)).

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/113/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables