issue_comments

Table actions

6 rows where issue = 32919692 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Most of Python 3 support · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
42624886 https://github.com/pydata/xarray/pull/113#issuecomment-42624886 https://api.github.com/repos/pydata/xarray/issues/113 MDEyOklzc3VlQ29tbWVudDQyNjI0ODg2 takluyver 327925 2014-05-09T01:17:46Z 2014-05-09T01:17:46Z MEMBER

Thanks, I've applied all of your suggestions.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Most of Python 3 support 32919692
42623348 https://github.com/pydata/xarray/pull/113#issuecomment-42623348 https://api.github.com/repos/pydata/xarray/issues/113 MDEyOklzc3VlQ29tbWVudDQyNjIzMzQ4 shoyer 1217238 2014-05-09T00:47:17Z 2014-05-09T00:47:17Z MEMBER

This looks very nice, I only have a few minor complaints which I will fix up before merging.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Most of Python 3 support 32919692
42456498 https://github.com/pydata/xarray/pull/113#issuecomment-42456498 https://api.github.com/repos/pydata/xarray/issues/113 MDEyOklzc3VlQ29tbWVudDQyNDU2NDk4 takluyver 327925 2014-05-07T17:23:25Z 2014-05-07T17:23:25Z MEMBER

OK, I've excluded that combination from Travis.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Most of Python 3 support 32919692
42361915 https://github.com/pydata/xarray/pull/113#issuecomment-42361915 https://api.github.com/repos/pydata/xarray/issues/113 MDEyOklzc3VlQ29tbWVudDQyMzYxOTE1 shoyer 1217238 2014-05-06T21:31:32Z 2014-05-06T21:31:32Z MEMBER

Looks like Pydap doesn't support Python 3 yet: robertodealmeida/pydap#7

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Most of Python 3 support 32919692
42360034 https://github.com/pydata/xarray/pull/113#issuecomment-42360034 https://api.github.com/repos/pydata/xarray/issues/113 MDEyOklzc3VlQ29tbWVudDQyMzYwMDM0 takluyver 327925 2014-05-06T21:16:48Z 2014-05-06T21:16:48Z MEMBER

OK, let's see how that goes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Most of Python 3 support 32919692
42359347 https://github.com/pydata/xarray/pull/113#issuecomment-42359347 https://api.github.com/repos/pydata/xarray/issues/113 MDEyOklzc3VlQ29tbWVudDQyMzU5MzQ3 shoyer 1217238 2014-05-06T21:10:35Z 2014-05-06T21:10:35Z MEMBER

This looks really awesome -- I will take a more careful look tonight. It would be helpful if you could update .travis.yml to also test against Python 3 just so it is more obvious which tests are failing.

I'm OK potentially merging this even if a few tests IO related are still failing in Python 3. It's pretty obvious that the NetCDF libraries have not been very heavily tested used with Python 3, and I probably have more context to resolve those issues than you do.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Most of Python 3 support 32919692

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);