issues: 324286237

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
324286237 MDExOlB1bGxSZXF1ZXN0MTg4OTMyODgx 2158 Fix dtype=S1 encoding in to_netcdf() 1217238 closed 0     3 2018-05-18T06:30:55Z 2018-06-01T01:09:45Z 2018-06-01T01:09:38Z MEMBER   0 pydata/xarray/pulls/2158
  • [x] Closes #2149 (remove if there is no corresponding issue, which should only be the case for minor changes)
  • [x] Tests added (for all bug fixes or enhancements)
  • [x] Tests passed (for all non-documentation changes)
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

@crusaderky please take a look. Testing here is not as thorough as in https://github.com/pydata/xarray/pull/2150 yet, but it does include a regression test.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2158/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables