issue_comments

Table actions

3 rows where issue = 324286237 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Fix dtype=S1 encoding in to_netcdf() · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
393575011 https://github.com/pydata/xarray/pull/2158#issuecomment-393575011 https://api.github.com/repos/pydata/xarray/issues/2158 MDEyOklzc3VlQ29tbWVudDM5MzU3NTAxMQ== shoyer 1217238 2018-05-31T15:43:46Z 2018-05-31T15:43:46Z MEMBER

I plan to merge this (and issue the 0.10.5 release) end of day today unless anyone has further comments.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix dtype=S1 encoding in to_netcdf() 324286237
391909155 https://github.com/pydata/xarray/pull/2158#issuecomment-391909155 https://api.github.com/repos/pydata/xarray/issues/2158 MDEyOklzc3VlQ29tbWVudDM5MTkwOTE1NQ== shoyer 1217238 2018-05-25T00:53:30Z 2018-05-25T00:53:30Z MEMBER

I think this is ready for another review.

@crusaderky I ended up splitting up your test into a few smaller pieces, so we could more easily handle logic for different backends with subclassing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix dtype=S1 encoding in to_netcdf() 324286237
390108777 https://github.com/pydata/xarray/pull/2158#issuecomment-390108777 https://api.github.com/repos/pydata/xarray/issues/2158 MDEyOklzc3VlQ29tbWVudDM5MDEwODc3Nw== crusaderky 6213168 2018-05-18T06:33:32Z 2018-05-18T06:33:32Z MEMBER

@shoyer just pull the test from #2150... 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix dtype=S1 encoding in to_netcdf() 324286237

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);